Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify annotation to dictionary construction #3

Open
nadiadavidson opened this issue Jan 6, 2025 · 1 comment
Open

Simplify annotation to dictionary construction #3

nadiadavidson opened this issue Jan 6, 2025 · 1 comment

Comments

@nadiadavidson
Copy link
Contributor

Current code is:

Convert dataframes to GRanges object

tx_grangesList <- blessy.dfToGRangesList(tx_df)
domain_grangesList <- blessy.dfToGRangesList(domain_df)

Map domains to transcripts

mapped_df <- blessy.mapDomainToTranscript(tx_grangesList, domain_grangesList, tx_df, domain_df)

It would be good to have a mapDomainToTranscript function that just takes the output from the UCSC tracks function and does the Granges coversion automatically. ie:

mapped_df <- blessy.mapDomainToTranscript(tx_df, domain_df)

The function:
mapped_df <- blessy.mapDomainToTranscript(tx_grangesList, domain_grangesList, tx_df, domain_df)
Is also a little odd in that it's taking the same information twice (ie. tx_df and tx_grangesList). Could it not just be:
mapped_df <- blessy.mapDomainToTranscript(tx_grangesList, domain_grangesList)?

@nadiadavidson
Copy link
Contributor Author

Following on from this and reading a little further into the documentation, I think what would be best are some methods that automate the whole dictionary creation starting with the annotations (as either a track name, a bed-like table or Granges file). ie.

blessy.createPhasingDictionary(genome,trans_track_name, domain_track_name)
blessy.createPhasingDictionary(tx_df, domain_df)
blessy.createPhasingDictionary(tx_grangesList, domain_grangesList)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant