Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't demand to set DATADOG_API_KEY if it's not used in favor of DATADOG_SOURCEMAP_INTAKE_URL #1524

Open
OnkelTem opened this issue Jan 14, 2025 · 1 comment
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] topic:environment-variables

Comments

@OnkelTem
Copy link

OnkelTem commented Jan 14, 2025

Bug description

I run npx datadog-ci sourcemaps upload ...

And I have DATADOG_SOURCEMAP_INTAKE_URL set, which means DATADOG_API_KEY isn't gonna be used.
And if it's not used, it shouldn't be required as it produces confusion.

P.S. Both of these variables are not covered in the docs.
P.P.S. Also every variable a CLI utility uses should also be accepted via CLI interface, which is not the case with the abovementioned vars.

Describe what you expected

No response

Steps to reproduce the issue

No response

Additional context

alpine docker image with node and stuff

Command

None

@OnkelTem OnkelTem added the bug Something isn't working label Jan 14, 2025
@Drarig29 Drarig29 added topic:environment-variables rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] labels Jan 15, 2025
@BenoitZugmeyer
Copy link
Member

Hi @OnkelTem

Even with DATADOG_SOURCEMAP_INTAKE_URL, metrics are sent to datadog using the API key. So it's still used and required.

Do you have any concern with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] topic:environment-variables
Projects
None yet
Development

No branches or pull requests

3 participants