Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sourcemaps upload to exit with non-zero status if an upload fails #1502

Open
Mahoney opened this issue Dec 10, 2024 · 0 comments
Open
Labels
enhancement New feature or request rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]

Comments

@Mahoney
Copy link

Mahoney commented Dec 10, 2024

Feature request description

We recently failed to notice our sourcemap uploads were not happening on CI because while datadog-ci sourcemaps upload prints out this output:

❌ Failed upload sourcemap for [/root/sourcemaps/assets/chunk.0af6818d23009e1ee6d2.js.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/chunk.0af6818d23009e1ee6d2.js.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/chunk.5391dbc251e49c1d6ba8.js.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/chunk.5391dbc251e49c1d6ba8.js.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/chunk.5e1a85b493ba7b5eda0e.js.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/chunk.5e1a85b493ba7b5eda0e.js.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/chunk.6dbf82364432e4ec7c89.js.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/chunk.6dbf82364432e4ec7c89.js.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/chunk.8a6e81b08a58ae81b886.js.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/chunk.8a6e81b08a58ae81b886.js.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/chunk.9e9a46c1f11250bd2e5d.js.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/chunk.9e9a46c1f11250bd2e5d.js.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/chunk.c8b5c1a0699b4c2025f5.js.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/chunk.c8b5c1a0699b4c2025f5.js.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/vendor.css.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/vendor.css.js)
❌ Failed upload sourcemap for [/root/sourcemaps/assets/vendor.js.map]: Missing corresponding JS file for sourcemap (/root/sourcemaps/assets/vendor.js)

it still exits 0, so we never knew.

Solution

There should be at least a flag to the command to make it exit non-zero if any of the uploads fail.

Additional context

No response

Command

sourcemaps

@Mahoney Mahoney added the enhancement New feature or request label Dec 10, 2024
@github-actions github-actions bot added the rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps] label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rum Related to [dsyms, flutter-symbols, unity-symbols, react-native, sourcemaps]
Projects
None yet
Development

No branches or pull requests

1 participant