Some model names changed in SnipeIT, osfv_cli does not recognize them

[philipandag]

Some model names changed in SnipeIT, osfv_cli does not recognize them. I've found that the MSI Z790-p DDR5 is no longer "supported" because it's name has changed. There might be more broken configurations there.

Traceback (most recent call last):
  File "/home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/rf/rte_robot.py", line 52, in __init__
    self.rte = RTE(rte_ip, dut_model_name, self.sonoff)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/libs/rte.py", line 39, in __init__
    self.dut_data = self.load_model_data()
                    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/libs/rte.py", line 50, in load_model_data
    raise UnsupportedDUTModel(f"The {file_path} model is not yet supported")
osfv.libs.rte.UnsupportedDUTModel: The /home/fgolas/work/open-source-firmware-validation2/venv/lib/python3.12/site-packages/osfv/models/MSI PRO Z790-P WIFI DDR5.yml model is not yet supported

MSI PRO Z790-P WIFI DDR5 is the name received from SnipeIT, but there is only a config for MSI PRO Z790-P DDR5.

RTE constructor called by RobotRTE constructor at src/osfv/rf/rte_robot.py:54
The dut_model_name is received via snipe-it api

asset_id = self.snipeit_api.get_asset_id_by_rte_ip(rte_ip)
status, dut_model_name = self.snipeit_api.get_asset_model_name(
    asset_id
)

Either the names at SnipeIT need to be reverted or the model config names need to be updated

[DaniilKl]

Got the same issue:

λ osfv_cli rte --rte_ip 192.168.10.127 flash write --rom msi_ms7e06_v0.9.1_ddr5.rom
DUT model retrieved from snipeit: MSI PRO Z790-P WIFI DDR5
Traceback (most recent call last):
  File "/home/danillklimuk/.local/bin/osfv_cli", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/danillklimuk/.local/lib/python3.12/site-packages/osfv/cli/cli.py", line 929, in main
    rte = RTE(args.rte_ip, dut_model_name, sonoff)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/danillklimuk/.local/lib/python3.12/site-packages/osfv/libs/rte.py", line 40, in __init__
    self.dut_data = self.load_model_data()
                    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/danillklimuk/.local/lib/python3.12/site-packages/osfv/libs/rte.py", line 55, in load_model_data
    raise UnsupportedDUTModel(
osfv.libs.rte.UnsupportedDUTModel: The /home/danillklimuk/.local/lib/python3.12/site-packages/osfv/models/MSI PRO Z790-P WIFI DDR5.yml model is not yet supported

Used config name change as a workaround.

[macpijan]

Either the names at SnipeIT need to be reverted or the model config names need to be updated

That's been done as an internal cleanup by @Stanislaw-bnk .

So I doubt snipeit would change, we need to change model names here.

Can I ask you to submit PR with your changes?