Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if CONFIG_AGESA_UCODE_EXPERIMENTAL is used by releases #860

Open
pietrushnic opened this issue Jun 4, 2024 · 4 comments
Open

Check if CONFIG_AGESA_UCODE_EXPERIMENTAL is used by releases #860

pietrushnic opened this issue Jun 4, 2024 · 4 comments

Comments

@pietrushnic
Copy link

There are some patches related to it like this, and the question is if that is not dead code?

@miczyg1
Copy link
Contributor

miczyg1 commented Jun 6, 2024

It may be dead, but it shouldn't. Some people still care about it.

@pietrushnic
Copy link
Author

This code is not used:

[13:22:36] pietrushnic:dasharo git:(pcengines/rel_v24.05.00.01-fixes) $ grep CONFIG_AGESA_UCODE_EXPERIMENTAL build/pcengines/apu2/v24.05.00.01/coreboot/.config
# CONFIG_AGESA_UCODE_EXPERIMENTAL is not set

I will schedule removal in next version.

@miczyg1
Copy link
Contributor

miczyg1 commented Jun 28, 2024

This code is not used:

[13:22:36] pietrushnic:dasharo git:(pcengines/rel_v24.05.00.01-fixes) $ grep CONFIG_AGESA_UCODE_EXPERIMENTAL build/pcengines/apu2/v24.05.00.01/coreboot/.config
# CONFIG_AGESA_UCODE_EXPERIMENTAL is not set

I will schedule removal in next version.

Don't... Of course we don't use it by default, because the ucode binary does not come from official source. It doesn't mean it is not used... People use it: pcengines/apu2-documentation#298

@pietrushnic
Copy link
Author

Ok, so maybe we should create a test for it. Otherwise, I'm not sure if after migration to Dasharo Patchqueue Initiative, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants