Fix build issue in dasharo-pq while building v24.05.00.01

[pietrushnic]

Using:

• This procedure
• This version of builder

I get the following compilation error:

i386-elf-ld.bfd: warning: build/cbfs/fallback/postcar.debug has a LOAD segment with RWX permissions
    Cloning SeaBIOS from Git
Cloning into 'seabios'...
remote: Total 16561 (delta 0), reused 16561 (delta 0)
Receiving objects: 100% (16561/16561), 3.57 MiB | 9.69 MiB/s, done.
Resolving deltas: 100% (13170/13170), done.
    Fetching new commits from the SeaBIOS git repo
    Checking out SeaBIOS revision rel-1.16.0.1
Already on 'master'
Your branch is up to date with 'origin/master'.
fatal: 'rel-1.16.0.1' is not a commit and a branch 'coreboot' cannot be created from it
make[1]: *** [Makefile:37: checkout] Error 128
make: *** [payloads/external/Makefile.mk:66: payloads/external/SeaBIOS/seabios/out/bios.bin.elf] Error 2
Build failed for apu2 with status code 2.

[pietrushnic]

At this point, coreboot knows nothing about PC Engine's custom SeaBIOS, so it should not use references from that repo.
Removal of REVISION and REVISION_ID is not enough because after:

diff --git a/configs/config.pcengines_apu2 b/configs/config.pcengines_apu2
index 30047f193202..50cff4b63fe3 100644
--- a/configs/config.pcengines_apu2
+++ b/configs/config.pcengines_apu2
@@ -21,8 +21,6 @@ CONFIG_PXE_ROM_ID="8086,157b"
 CONFIG_IPXE_SCRIPT="payloads/external/iPXE/menu.ipxe"
 CONFIG_SEABIOS_BOOTORDER_FILE="$(top)/src/mainboard/$(MAINBOARDDIR)/variants/$(CONFIG_VARIANT_DIR)/bootorder"
 CONFIG_SEABIOS_DEBUG_LEVEL=0
-CONFIG_SEABIOS_REVISION=y
-CONFIG_SEABIOS_REVISION_ID="rel-1.16.0.1"
 CONFIG_SEABIOS_SERCON_PORT_ADDR=0x3f8
 CONFIG_SUBSYSTEM_DEVICE_ID=0x0000
 CONFIG_SUBSYSTEM_VENDOR_ID=0x0000
diff --git a/configs/config.pcengines_apu4 b/configs/config.pcengines_apu4
index e4179afe6ab0..44ea384ccfef 100644
--- a/configs/config.pcengines_apu4
+++ b/configs/config.pcengines_apu4
@@ -22,8 +22,6 @@ CONFIG_PXE_ROM_ID="8086,1539"
 CONFIG_IPXE_SCRIPT="payloads/external/iPXE/menu.ipxe"
 CONFIG_SEABIOS_BOOTORDER_FILE="$(top)/src/mainboard/$(MAINBOARDDIR)/variants/$(CONFIG_VARIANT_DIR)/bootorder"
 CONFIG_SEABIOS_DEBUG_LEVEL=0
-CONFIG_SEABIOS_REVISION=y
-CONFIG_SEABIOS_REVISION_ID="rel-1.16.0.1"
 CONFIG_SEABIOS_SERCON_PORT_ADDR=0x3f8
 CONFIG_SUBSYSTEM_DEVICE_ID=0x0000
 CONFIG_SUBSYSTEM_VENDOR_ID=0x0000

A newly built issue appear:

i386-elf-ld.bfd: warning: build/cbfs/fallback/postcar.debug has a LOAD segment with RWX permissions
    Cloning SeaBIOS from Git
Cloning into 'seabios'...
remote: Total 16561 (delta 0), reused 16561 (delta 0)
Receiving objects: 100% (16561/16561), 3.57 MiB | 9.72 MiB/s, done.
Resolving deltas: 100% (13170/13170), done.
    Checking out SeaBIOS revision a6ed6b701f0a57db0569ab98b0661c12a6ec3ff8
Already on 'master'
Your branch is up to date with 'origin/master'.
Switched to a new branch 'coreboot'
    CONFIG     SeaBIOS a6ed6b701f0a57db0569ab98b0661c12a6ec3ff8
Error: File /home/coreboot/coreboot/src/mainboard/pcengines/apu2/seabios_config does not exist
make[1]: *** [Makefile:46: config] Error 1
make: *** [payloads/external/Makefile.mk:66: payloads/external/SeaBIOS/seabios/out/bios.bin.elf] Error 2
Build failed for apu2 with status code 2.

removal of CONFIG_PAYLOAD_CONFIGFILE helps with the above issue but leads to another one:

Total size: 119200  Fixed: 66112  Free: 11872 (used 90.9% of 128KiB rom)
  Creating out/bios.bin.elf
make: *** No rule to make target '/home/coreboot/coreboot/src/mainboard/pcengines/apu2/variants/apu2/bootorder', needed by 'build/coreboot.pre'.  Stop.
Build failed for apu2 with status code 2.

Matrix thread related to other issues caused by coreboot-sdk 2024-05.

Finally, fix required updating configs as well as iPXE version so it could be compiled with quite recent coreboot-sdk:

• Dasharo/dasharo-pq@7bf7bf1
• Dasharo/dasharo-pq@4f518ff

[pietrushnic]

With the above changes, apu2 and apu4 compile without issues.