Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing priority of meta-dts-distro #769

Closed
DaniilKl opened this issue Mar 29, 2024 · 6 comments
Closed

Changing priority of meta-dts-distro #769

DaniilKl opened this issue Mar 29, 2024 · 6 comments

Comments

@DaniilKl
Copy link
Contributor

Dasharo version (if applicable)

Dasharo Tools Suite built on commit 386e4d402abd29661b88c76e0ef5bb6568766dac.

Dasharo variant (if applicable)

Affected component(s) or functionality (if applicable)

meta-dts-distro layer.

Brief summary

Considering changing meta-dts-distro priority to 11.

Additional context

  • Reason: DTS layers should have higher priority in the build, otherwise recipes from meta-dts-distro will be overwritten by other layers whenever it is possible and lead to errors or misunderstanding.
  • Example: on commit 386e4d402abd29661b88c76e0ef5bb6568766dac (which is latest develop branch) recipe hidapi_1.4.1.bb from meta-dts-distro is being overwritten during build by recipe hidapi_git.bb from meta-openembedded. This can be verified by checking workdir of the package hidapi after build:
λ ls build/tmp/work/core2-64-dts-linux/hidapi
0.11.2-r0

Which matches version from the recipe from meta-openembedded, which is:

λ cat ./meta-oe/recipes-support/hidapi/hidapi_git.bb
(...)
PV = "0.11.2"
(...)
@DaniilKl
Copy link
Contributor Author

Found out about this during digging in issue #729.

@artur-rs
Copy link
Member

@TomaszAIR please review the idea in this issue

DaniilKl added a commit to Dasharo/meta-dts that referenced this issue May 22, 2024
This recipe was not used in the builds, instead recipe from meta-openembedded is
being used. Surplus metadata should be deleted.

Refs:
Dasharo/dasharo-issues#770
Dasharo/dasharo-issues#769

Signed-off-by: Daniil Klimuk <[email protected]>
@macpijan
Copy link
Contributor

why label invalid? Do we want to implement this, or not? If not, let’s simply close.

@artur-rs
Copy link
Member

artur-rs commented Jul 4, 2024

@DaniilKl ping, question above

@DaniilKl
Copy link
Contributor Author

DaniilKl commented Jul 4, 2024

why label invalid?

My bad.

Do we want to implement this, or not?

I still think we should implement this, but the team opinion was to live it the way it is.

@DaniilKl DaniilKl removed the invalid This doesn't seem right label Jul 4, 2024
tym2k1 added a commit to Dasharo/meta-dts that referenced this issue Sep 9, 2024
tym2k1 added a commit to Dasharo/meta-dts that referenced this issue Sep 11, 2024
PLangowski pushed a commit to Dasharo/meta-dts that referenced this issue Sep 27, 2024
This recipe was not used in the builds, instead recipe from meta-openembedded is
being used. Surplus metadata should be deleted.

Refs:
Dasharo/dasharo-issues#770
Dasharo/dasharo-issues#769

Signed-off-by: Daniil Klimuk <[email protected]>
PLangowski pushed a commit to Dasharo/meta-dts that referenced this issue Sep 27, 2024
PLangowski pushed a commit to Dasharo/meta-dts that referenced this issue Sep 27, 2024
PLangowski pushed a commit to Dasharo/meta-dts that referenced this issue Sep 27, 2024
This recipe was not used in the builds, instead recipe from meta-openembedded is
being used. Surplus metadata should be deleted.

Refs:
Dasharo/dasharo-issues#770
Dasharo/dasharo-issues#769

Signed-off-by: Daniil Klimuk <[email protected]>
PLangowski pushed a commit to Dasharo/meta-dts that referenced this issue Sep 27, 2024
@m-iwanicki
Copy link

@DaniilKl can be closed? Priority was increased to 9 in: Dasharo/meta-dts@2442ec3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants