From 9f04a2d4a60afd34967fa4de05e670e49f92d0e8 Mon Sep 17 00:00:00 2001
From: Daniel Schaffer <dan@dandoes.net>
Date: Fri, 23 Aug 2019 14:21:58 -0700
Subject: [PATCH] core: add example using jQuery with es6 and `expose-loader`,
 add documentation for using `expose-loader`

fixes #34
---
 .yarn-offline-mirror/expose-loader-0.7.5.tgz | Bin 0 -> 3580 bytes
 README.md                                    |   5 ++
 examples/es6-jquery/README.md                |   1 +
 examples/es6-jquery/e2e-config.json          |   4 ++
 examples/es6-jquery/package-lock.json        |  13 +++++
 examples/es6-jquery/package.json             |   7 +++
 examples/es6-jquery/src/commonjs-five.js     |   3 ++
 examples/es6-jquery/src/entry.js             |  22 ++++++++
 examples/es6-jquery/src/four.js              |   1 +
 examples/es6-jquery/src/one.js               |   1 +
 examples/es6-jquery/src/three.js             |   1 +
 examples/es6-jquery/src/two.js               |   1 +
 examples/es6-jquery/webpack.config.js        |  50 +++++++++++++++++++
 package.json                                 |   1 +
 yarn.lock                                    |   5 ++
 15 files changed, 115 insertions(+)
 create mode 100644 .yarn-offline-mirror/expose-loader-0.7.5.tgz
 create mode 100644 examples/es6-jquery/README.md
 create mode 100644 examples/es6-jquery/e2e-config.json
 create mode 100644 examples/es6-jquery/package-lock.json
 create mode 100644 examples/es6-jquery/package.json
 create mode 100644 examples/es6-jquery/src/commonjs-five.js
 create mode 100644 examples/es6-jquery/src/entry.js
 create mode 100644 examples/es6-jquery/src/four.js
 create mode 100644 examples/es6-jquery/src/one.js
 create mode 100644 examples/es6-jquery/src/three.js
 create mode 100644 examples/es6-jquery/src/two.js
 create mode 100644 examples/es6-jquery/webpack.config.js

diff --git a/.yarn-offline-mirror/expose-loader-0.7.5.tgz b/.yarn-offline-mirror/expose-loader-0.7.5.tgz
new file mode 100644
index 0000000000000000000000000000000000000000..bff1372aa808709b1a3d14fd1c0070d69571d2d5
GIT binary patch
literal 3580
zcmV<Y4FmEYiwFP!000006YV-{ciKp@^ELVv6_PuE0}>BoCywp8#Ks953|=6U&GGdP
z4QikhA!*eT#GB2(*?+QsY^%Ck7_gI^<2+_(uXTJZ)ZO*$>Uv2b8@*!_?u7bozm<Xi
z(>K0KrP9v!HrzChSGiKDt<ROprCMnReky%yMsB(i8M6pk`C2?$7+Bu_AlC;AAmg(c
z&+I{lzYhb+i(bH79%TwNHRq8Oflsp~d)Kb%QI^EhAfmy3FceI}%ODJKCH$`p-bG9=
za=9EuB8&~VMh+S|%mO#@IE;e`7JNw7r-3{%;=WYeoHqM<Y{rDbAbgj<M+?=X+@A=a
zOPnAXNQ%H!aEAx5ZC7C*YIeyk!9V^1I8w9Ar3|k7s9-f?E3gswIMZa&9(<QYZZQ>o
z3FY#TBMbgWXtL?({CHzR<Gh9lk^gnuuGlM#gq%k=L#J9Hph_ypU#rVs+w|)SQN&TZ
zA`YTUf|$l}DEAy^BI0Q>v`4|rG5Ct3z>gy_bk_FT#)Vp|!(<|FgTWC}CfsbzG??)a
zy~%A5Wvq|Z?|mr#A6>@pJ7fVYrtL^#F25~}&-;Iz+;Eqra=BdEz4QM+;xhY>hi~*w
z1%D{IVm!9CAm;Dm19bF(H59(H1w8N$yz%eN@7?unuk`#My{NaJH(H(N_RRg(G(La+
zE7j`m`W)terRrV&_d~7+a5QE9ghMNsSXSNhzz<?J#MEr0#wEl7#8V+5jDoj(6vIN`
zq9F%27$r0A$J_<s>m_61aT|J^!}(_NbCJ6t5x@jsju>#7c|}dn3ntDcY+j{_2rv^d
zOcLR8k1{{ovi2EJ?s{Ny)5Cp-9a;|_z`1(9k>=;K7+evuh&yvaux;D6`ccb6u2L#L
zE|#jr(v!SpA&m#{ESbQGc+aJU-g0ZpoTR<2Enuz-14D?C&$&w029O(U=6eIgeEwi(
z_ZF<`gv;64%@YonjjK;MyPe3WSH~d8lXUBP-M-SRdQ`gDEtbp0^5akFV#?%{6d`=1
zDTR!2mw^V+o@g(JiSS%Wc0<92M>Oq<NZO>0%H!K>qw-j3gO7RbiOX-V4TAu+LE=Q5
zN)X{sy8LfQB_`1#E(34Q0Tg9eOt}xU#EV6UXJ^hLL5D~J8WU&=u97^Sa*(K6gjcAP
z#MRR6C9al~#MNqT{Dkk^USfklNsJX(f_x7W$s;530Ps{^N=STx&uGcIfU{SZC|j<5
z#qQPg?$ydWl_zZb_OciRD9i8dUjO5-H2$Zx_4lChh4{aFE&i8wcXsdM{|~vGE$iNC
zvkxuZcL6$bc;Xg|g&km+l0g!UxE(|j$8=_-gD0$L9_(-$TKDRz8w5ADf~+mavd|qu
z$l@s+D7Pmfp3Bm6HviPJ#)&_o6ad(0gg!Ou;kouFxjFL^o`(<CJ%S!hF<_iU$Wjzz
z*hEBX-j<;!;#|hgASSiY<Nibu+JLb2gjp5p@k>n$S7#<(Fl1iF%%gKhS5D(NV%<Z>
zougraBc-Q!+c$LZ_oGLO$$Mg)6L1KnJpR6C;2$9Z9KWA|N1G%cK_(A3k0X%}AD{l8
zPt4rgoJNf21oo$1r)^6$D8`q$4QbECMV?Sy5RQ*1!3smhag*bWV$$SwE}jxVoJ77+
z#8V4#T!TwDE|({MH|Fh7#G~ozs?8v()aE#8{z-w+#6%cJ!3>xW4jTqu5>t0No}zQ2
zT$JG|kHrE*ubqx7Jbj&{a>^(roR6l7|Bh0Q3vDV=V^vuuX;KC3DDi#upreYy^NHL9
zQ{NyWL$dBsP7{OA7e<n^)U?+Hv?CsRY{YZ8jg%hSlrqq9qV)wF%-UH}J;@+>nEp(~
z%PAO&b6AKM;2H)rG%|X<ijAgRW$i!z4C^B~T0};uhLN%8GLK85U_lZ<BZ|<tGin^^
zN0^$#94%eK41+QXLnn(GlISSt23znth~BX%NPHKwfmnE^muq`s*u=CpMteZz8I`61
z8?!&(rG!Wo3Zoz*g?g8^L7L(oQx3V8J{95CnMCdDacn;^I2@zp->&C8xb2^udIZ^`
zN&T`{Cu-fxU2TdjlOdkxTsfaNP5{p(8c8Pgm^YmIOi{U(bxTy>`KNgD@lbxz|EKZ4
z)jVpndyVfBW4;joulN5-yOm1yF8=?B%Q_0e%ScS7F&Y<~(5YrR8sqT}&?!^l?d!g9
z5Mg<D#v|n!a0wn{oae(!m_&>k0R{B2So{ZLa<kEd7nH;H(Xn7cfB?ZT)*jMgh&8;V
zmC7H;U>q-~R3fTO%3vfIH5SqygJy}^3li|ma4Xw05ZSyU;&SHcHUx)s3Kn?agCwRP
zh61Q4RG^a7OI+e1o%X~`7z!!~kup@M!NXiod=|*X;eo?DS7L?9&=V4!xGSXTnHNCP
zph}AhB!`13k>s977${{?vR-kg)*uxtB!$LCMT+iXih*iP66&p>^FWf^RpJJyGDT6f
zWDpB29|xWnEGVAgmbro?LSJh2aS8(|2F%fNul*oKRy7MMZeH!GnUYhc`aG6anC|kh
z6>%a^9t$^KpzbN?6TM9_ZKVIA0lm&i|8>3FfMyTQx}9H}$Bkpi)_eGzEx_w$|3&9j
zA8<vt-tNDF&I#1pZ{TIKeO#~_e>v+mdOhfLp?P}NYBr7w&}<*IUL7~v&*2%uwL6%=
zHZhGwr2P&ML4&H<K)4g@w9%yoXTSce*=qLR6yT)UZxhZFL|TWldbi&^dey3T;p|oS
ztkY{C`C~-eZnjUlNTqSwX!mWa*~T$w{E83Idr@z-6sh_v<i4x;JL;Uh={BFg=);Rn
z>$rh~&l<>C{aLG_NwwctN3DAEv;fET)B5v<g6bfau3Bced;OxJhLBzz|Bm|2PMdUc
z)M@v-_*k&|oo;^#`nuU`6rkR1_DCTo-43EBbs|JZAwjryLt`OT6W7*qM{o&A@v7Ij
z;^nweZy~N80k3YKeOFNbmtAT6?>6ekr;YE>{Qv1o@qf2gD#OM&j#cjB|BtxN@1OhO
z>_Yuh|BFfFU068m@=#vr|N6F^!QdWW=>PhrXRLi!%rQiWiGPq8(VKxNbBHPQ{{3PR
zOf95hGUdQYgaIDBU=jegC%QIE6ZJ(9dG1^lT(m%C>`*K!TnwfWA0K??vx4-lXd{G}
zVSOjuczTejlu8*)SttUUhq=V1{2+tF=2xYb(P=-(Xmmwq<ob5R7D#T5){MJ?Ied5f
zag7fv4zcS9jJ~#<PqgsVImg?yeAv(*z_e76vG3prO@xOOpVvQ*VJ;S+x}q@eUpVLn
z1*T9G@oio0;veQH<HS>~WtR_=3Dvd*3eMLwWmv{?S+#T2dlc!&shG_W#>pJYBverx
z^9L;DB1Y9Nl4e-`sy7yZ$-&hGW&@ffNg~=PhqdpZ0UV+oOe>pa(8P)vlLwT#f(r(N
z!4NBR3(XA#tQB9l&yvkKEx8fVm&8Kdk9ZhMN28OO!&egh8}Vp}Z*8@Mm~U<E!Ku;k
z41EB-(Hf+sR(_Cmm8GJP_;-mlHw+W1UzKWcJ1+HWFwB*#;j+PRE6Lz3n=}1^k+rPd
z)@1xeYw@y;#rA#MQE$!ON-DG+2eg$)wdZNCg?87h+As&x9-ysBTR8L$)e?QiCY()G
zj>8a(eymSr0h#yRU}3K;BwLE9C4$Tgj~WNI-h&gQ&EK<GNWyzO&SJLCE=eb_z}%1c
zF~<A$&#H;QB(NoWxaXKT4jvBnly2V2PpRbL{kN(NCM_ts{b_=X4h*Lc2iF-)^L-;0
z=|Tp?w^jGhR(y0Y9;WQX>4^E5i^n?GO?MR6kHthO7P(9N6!S8kDYO{Fu0DnOt1M$u
zdvLBi#0QA!T~ON6w9Ol#Tqc#IU?4WXto!9*20kK+3+tnjbxFGNNzxG+DiZ!+d=p(a
zQ_pJZSQo7<MK7@dOjpWXc8$AiVPjbk>PiB#53?&%A1|!s4=sn)S~CxH4Z)_3V4;Kd
zk?yLtn1QM+TwSox+N({smH91Ss~IHej-pgBxUayC^U$r4AHAFR*Ppdi8U112A8wB|
z_iGzn`0j>7A@F>#A?D!f1t5LeX&gKYg@azjp2jopfr*j78OYxZWZn|wgxUy2E|a_v
z<Pu+XR&@b=jn+!b(n3!<;;Q+Xw{KWE5p(p<WQ5d-U_+^T)cOU7@y_P!*4!ZD*tU&4
zhe`y~C6rFY*(lck$@348PESEv#>4~PLr)rpp18^Y)bh013Uv&~f{vS7n!aLIUF}4s
z-(+x0hb`N>F_@k*;ZsKjkAVq}`|8^dm6*iCz`Zm%R2&_eJ=>4n8&W(ow~}g=Yb&W1
zJuFwPrB&$6G5wZRTjz1qK2;&j*J)Pbly`QXRLZ~152`=Q1H!XH&KX84PoK#QhaBVF
zB6IksWE#M)n9Ba^pWeUziE{fUJ=5r7_xnm&`J|MOw=1RXC#A0x)2+@0y4#Y^QPe<A
z69%sZ_vH^2^3z*ct5$c)J6|bdkFxZa)#~3fhc7vvjh9{`-~H#vSluo?F7JM=kmwFu
zEPB`U{mfyHW2B=eakH`FuW0qW;<G-&mZgfiy=7U2;@X(*bI+Bw2ppVr<{O`ZW7T3U
zi@+;L9C<4hXKA}&4Gbx%GVuz)Wpm*c-I?;(pa1e)kzAISw?TpARW15SNr%iumQlaB
z|3!o9e<~*_(xGaJP9n~I&CRl;-CKQkguu4AR%PBb#O|)U>+braUjGK|r(4SaH~;{T
CSP?-0

literal 0
HcmV?d00001

diff --git a/README.md b/README.md
index 3127dff..f9614e8 100644
--- a/README.md
+++ b/README.md
@@ -79,6 +79,11 @@ be customized (see [Options Reference](#options-reference) below)
 
 * Vue
   * Replace `'vue-loader'` with `BabelMultiTargetPlugin.loader('vue-loader')`
+  
+* `expose-loader`
+  * Rules using `expose-loader` must be defined _before_ rules using `BabelMultiTargetPlugin.loader()`
+  * Do not `import`/`require` libraries exposed with `expose-loader` - either reference them from the global scope,
+    or do not use `expose-loader`. You may also need to use Webpack's `ProvidePlugin`.
 
 ## Upgrading from v1.x
 
diff --git a/examples/es6-jquery/README.md b/examples/es6-jquery/README.md
new file mode 100644
index 0000000..91a9ab0
--- /dev/null
+++ b/examples/es6-jquery/README.md
@@ -0,0 +1 @@
+# Example: ES6 (jQuery)
diff --git a/examples/es6-jquery/e2e-config.json b/examples/es6-jquery/e2e-config.json
new file mode 100644
index 0000000..9b072cd
--- /dev/null
+++ b/examples/es6-jquery/e2e-config.json
@@ -0,0 +1,4 @@
+{
+  "angular": false,
+  "e2e_ready": true
+}
diff --git a/examples/es6-jquery/package-lock.json b/examples/es6-jquery/package-lock.json
new file mode 100644
index 0000000..f2b6b04
--- /dev/null
+++ b/examples/es6-jquery/package-lock.json
@@ -0,0 +1,13 @@
+{
+  "name": "webpack-babel-multi-target-plugin-example-es6-jquery",
+  "version": "0.0.0",
+  "lockfileVersion": 1,
+  "requires": true,
+  "dependencies": {
+    "jquery": {
+      "version": "3.4.1",
+      "resolved": "https://registry.npmjs.org/jquery/-/jquery-3.4.1.tgz",
+      "integrity": "sha512-36+AdBzCL+y6qjw5Tx7HgzeGCzC81MDDgaUP8ld2zhx58HdqXGoBd+tHdrBMiyjGQs0Hxs/MLZTu/eHNJJuWPw=="
+    }
+  }
+}
diff --git a/examples/es6-jquery/package.json b/examples/es6-jquery/package.json
new file mode 100644
index 0000000..6ce2ace
--- /dev/null
+++ b/examples/es6-jquery/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "webpack-babel-multi-target-plugin-example-es6-jquery",
+  "version": "0.0.0",
+  "dependencies": {
+    "jquery": "^3.4.1"
+  }
+}
diff --git a/examples/es6-jquery/src/commonjs-five.js b/examples/es6-jquery/src/commonjs-five.js
new file mode 100644
index 0000000..0646261
--- /dev/null
+++ b/examples/es6-jquery/src/commonjs-five.js
@@ -0,0 +1,3 @@
+const foo = () => console.log('commonjs 5')
+
+module.exports = foo
diff --git a/examples/es6-jquery/src/entry.js b/examples/es6-jquery/src/entry.js
new file mode 100644
index 0000000..2ca6792
--- /dev/null
+++ b/examples/es6-jquery/src/entry.js
@@ -0,0 +1,22 @@
+console.log('entry!')
+
+import { GTG } from '../../_shared/constants'
+import { createDom } from '../../_shared/es6-dom'
+import { makeItGreen } from '../../_shared/make.it.green'
+import { es6 } from '../../_shared/logos'
+import ready from '../../_shared/ready'
+
+require('./commonjs-five')
+
+Promise.all([])
+
+async function init() {
+  const dom = createDom('es6-jquery', es6)
+
+  makeItGreen()
+
+  dom.setStatus(GTG)
+  ready()
+}
+
+$(init)
diff --git a/examples/es6-jquery/src/four.js b/examples/es6-jquery/src/four.js
new file mode 100644
index 0000000..2062fe8
--- /dev/null
+++ b/examples/es6-jquery/src/four.js
@@ -0,0 +1 @@
+console.log('4')
diff --git a/examples/es6-jquery/src/one.js b/examples/es6-jquery/src/one.js
new file mode 100644
index 0000000..62bb704
--- /dev/null
+++ b/examples/es6-jquery/src/one.js
@@ -0,0 +1 @@
+console.log('1')
diff --git a/examples/es6-jquery/src/three.js b/examples/es6-jquery/src/three.js
new file mode 100644
index 0000000..a35be70
--- /dev/null
+++ b/examples/es6-jquery/src/three.js
@@ -0,0 +1 @@
+console.log('3')
diff --git a/examples/es6-jquery/src/two.js b/examples/es6-jquery/src/two.js
new file mode 100644
index 0000000..1f88295
--- /dev/null
+++ b/examples/es6-jquery/src/two.js
@@ -0,0 +1 @@
+console.log('2')
diff --git a/examples/es6-jquery/webpack.config.js b/examples/es6-jquery/webpack.config.js
new file mode 100644
index 0000000..bc81039
--- /dev/null
+++ b/examples/es6-jquery/webpack.config.js
@@ -0,0 +1,50 @@
+const { ProvidePlugin } = require('webpack')
+
+const BabelMultiTargetPlugin = require('../../').BabelMultiTargetPlugin
+
+/**
+ * @type {Configuration}
+ *
+ * this configuration is merged with ~/examples/webpack.common.js
+ **/
+module.exports = {
+
+  entry: {
+    'main': [
+      './src/one.js',
+      './src/two.js',
+      './src/three.js',
+      './src/four.js',
+      './src/entry.js',
+    ],
+  },
+
+  module: {
+    rules: [
+      {
+        test: /node_modules\/jquery/,
+        use: [
+          {
+            loader: 'expose-loader',
+            options: 'jQuery',
+          },
+          {
+            loader: 'expose-loader',
+            options: '$',
+          },
+        ],
+      },
+      {
+        test: /\.js$/,
+        use: BabelMultiTargetPlugin.loader(),
+      },
+    ],
+  },
+  plugins: [
+    new ProvidePlugin({
+      $: 'jquery',
+      jQuery: 'jQuery',
+    }),
+  ],
+
+}
diff --git a/package.json b/package.json
index b7fdb38..696fac2 100644
--- a/package.json
+++ b/package.json
@@ -109,6 +109,7 @@
     "eslint": "^5.12.0",
     "eslint-plugin-import": "^2.14.0",
     "eslint-plugin-mocha": "^5.2.0",
+    "expose-loader": "^0.7.5",
     "express": "^4.16.4",
     "express-history-api-fallback": "^2.2.1",
     "file-loader": "^3.0.1",
diff --git a/yarn.lock b/yarn.lock
index d24767e..da3078f 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3156,6 +3156,11 @@ expand-brackets@^2.1.4:
     snapdragon "^0.8.1"
     to-regex "^3.0.1"
 
+expose-loader@^0.7.5:
+  version "0.7.5"
+  resolved "https://registry.npmjs.org/expose-loader/-/expose-loader-0.7.5.tgz#e29ea2d9aeeed3254a3faa1b35f502db9f9c3f6f"
+  integrity sha512-iPowgKUZkTPX5PznYsmifVj9Bob0w2wTHVkt/eYNPSzyebkUgIedmskf/kcfEIWpiWjg3JRjnW+a17XypySMuw==
+
 express-history-api-fallback@^2.2.1:
   version "2.2.1"
   resolved "https://registry.npmjs.org/express-history-api-fallback/-/express-history-api-fallback-2.2.1.tgz#3a2ad27f7bebc90fc533d110d7c6d83097bcd057"