From a1dd55e1e35c2de1c5a31529a10a2af087dc6a4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jerry=20Lundstr=C3=B6m?= Date: Wed, 12 Aug 2020 15:52:27 +0200 Subject: [PATCH] getline - Fix sonar issues by checking the buffer returned by `getline()` --- src/config_hooks.c | 2 +- src/parse_conf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/config_hooks.c b/src/config_hooks.c index 8cd6c7fb..08f8b18f 100644 --- a/src/config_hooks.c +++ b/src/config_hooks.c @@ -638,7 +638,7 @@ int load_knowntlds(const char* file) new_KnownTLDS[new_size] = "."; new_size++; - while (getline(&buffer, &bufsize, fp) > 0) { + while (getline(&buffer, &bufsize, fp) > 0 && buffer) { for (p = buffer; *p; p++) { if (*p == '\r' || *p == '\n') { *p = 0; diff --git a/src/parse_conf.c b/src/parse_conf.c index 79a210d8..d22d4f69 100644 --- a/src/parse_conf.c +++ b/src/parse_conf.c @@ -1162,7 +1162,7 @@ int parse_conf(const char* file) if (!(fp = fopen(file, "r"))) { return 1; } - while ((ret2 = getline(&buffer, &bufsize, fp)) > 0) { + while ((ret2 = getline(&buffer, &bufsize, fp)) > 0 && buffer) { memset(tokens, 0, sizeof(conf_token_t) * PARSE_MAX_ARGS); line++; /*