Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow Gymnasium Composite Spaces #1868

Closed
2 tasks done
flowerthrower opened this issue Mar 14, 2024 · 2 comments
Closed
2 tasks done

[Feature Request] Allow Gymnasium Composite Spaces #1868

flowerthrower opened this issue Mar 14, 2024 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@flowerthrower
Copy link

flowerthrower commented Mar 14, 2024

🚀 Feature

Allow gymnasium composite spaces like gymnasium.spaces.Sequence or gymnasium.spaces.Graph when providing a custom feature extractor (which supports those).

Motivation

Users that create a custom feature extractor to map observations of variable size (e.g. through graph or recurrent NNs) to fixed size output vectors can still not use policies like PPO without having to modify SB3 checks and constraints that prevent the user from using a variable size environment.

Pitch

This does not require models to support those spaces but only to allow the user to use them with custom provided feature extractors.

Alternatives

No response

Additional context

No response

Checklist

  • I have checked that there is no similar issue in the repo
  • If I'm requesting a new feature, I have proposed alternatives
@flowerthrower flowerthrower added the enhancement New feature or request label Mar 14, 2024
@araffin araffin added the duplicate This issue or pull request already exists label Mar 14, 2024
@araffin
Copy link
Member

araffin commented Mar 14, 2024

Duplicate of #1688 #1723 and #1280

Are you willing to contribute such feature?

@flowerthrower
Copy link
Author

I am afraid my current understanding of the package is too shallow for contributing right now.
Since this is one of multiple duplicates I hope the original request can be implemented in the future.

@flowerthrower flowerthrower closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants