Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De/Compressor detection will not work properly in all cases #3

Open
dankwart-de opened this issue Jun 28, 2018 · 1 comment
Open

De/Compressor detection will not work properly in all cases #3

dankwart-de opened this issue Jun 28, 2018 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@dankwart-de
Copy link
Contributor

The current detection code is:

      for (int i = 0; i < er.resultLines.size(); i++) {
            //Look at Matthias ExomePipeline extension. The code is mainly taken from there.
            String dCString = null
            String dRString = "gzip -c" //POSSIBLE-ERROR: Not zipper set for 'cat'/ASCII
            String type = er.resultLines[i]
            if (type.startsWith("setgid "))
                type = type[7..-1].trim().split(" ")[0]
            if (type == "0") continue
            if (type == "gzip") {
                dCString = "gunzip -c"
                dRString = "gzip -c"
            } else if (type == "bzip2") {
                dCString = "bunzip2 -c -k"
                dRString = "bzip2 -c -k"
            } else if (type == "ASCII" || type == "ASCII text") {
                dCString = "cat"
                dRString = "head -n E"
            }
            allLaneFiles[i].setDecompressionString(dCString)
            allLaneFiles[i].setRecompressionString(dRString)
        }

file -bL used to work? (or we did not recognize that it never worked properly due to other circumstances). It needs to recognize strings e.g. from:

ASCII text with very long lines
@dankwart-de dankwart-de added enhancement New feature or request bug Something isn't working labels Jun 28, 2018
@vinjana
Copy link
Member

vinjana commented Jul 4, 2018

What do you mean, it needs to recognize strings? Can you add a test file where it fails and the desired outcome?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants