Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Missing redirect URI leads to problems during onboarding #14

Open
saschadoemer opened this issue Jul 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@saschadoemer
Copy link
Member

Contact Details

No response

What happened?

I experienced an authorization error during the onboarding process, after creating the application. The application said, that there was a failure to process authorization.

chrome_W34QiphGAY

I took a look into the developer console and saw, that there was an HTTP 400 on the request.

chrome_FB64bXVmZJ

I then checked the payload and realized, that the redirect_uri is missing within the request.

chrome_HAr0PAjntF

After adding the missing information, the onboarding response was redirected to the application.

chrome_1Q00vDyT33

Since the former implementation of the agrirouter did only use a single field to provide a redirect URL, the addition of the deep URL could be misleading and adding the redirect URL can be easily forgotten - @oliverrahner, wdyt?

I think at least one redirect URL should be mandatory, since the request relies on the information and the onboarding process will fail otherwise.

agrirouter SDK

Java

Support Data

No response

Additional information

No response

@saschadoemer saschadoemer added the bug Something isn't working label Jul 25, 2024
@oliverrahner
Copy link
Member

Thanks for the report!

Unfortunately, there are some edge cases that we know of which explicitly don't need a redirect URL. Example would be a Farming Software that is running locally on a Desktop. While you could use a redirect in those cases as well, there are implementations solely relying on entering a registration code.

What we could, and should, probably do though, is show some kind of a warning next to the Redirect URL setting if you didn't set any, to put the focus there.

And then also handle this case more gracefully during authorization.

@oliverrahner oliverrahner added enhancement New feature or request and removed bug Something isn't working labels Aug 26, 2024
@oliverrahner
Copy link
Member

Reclassified as future enhancement because of the statement above

@oliverrahner oliverrahner changed the title [Bug] Missing redirect URI leads to problems during onboarding [Enhancement] Missing redirect URI leads to problems during onboarding Aug 26, 2024
@tim-reply
Copy link

tim-reply commented Oct 25, 2024

Hey, we have just rolled out a small related improvement in the authorization process, one of two that Oliver mentions above. Now when user opens authorize page with wrong redirect URI, they would see error page right away, without showing Connect button.

This would look approximately like this (wording of error messages might change a bit though):
image
and in mobile resolutions:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants