Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: a button that untoggles all syllables #1283

Closed
JoyfulGen opened this issue Feb 3, 2025 · 5 comments
Closed

Feature request: a button that untoggles all syllables #1283

JoyfulGen opened this issue Feb 3, 2025 · 5 comments
Labels
feature-request

Comments

@JoyfulGen
Copy link
Contributor

Just for fun! Sometimes toggled syllables just bug me. I think the button could go in the MEI Actions dropdown menu. @yinanazhou, what do you think?
yinanazhou added a commit that referenced this issue Feb 3, 2025
@yinanazhou
feat: add Untoggle All Toggled Syllables MEI action
c6bbe37 
refs: #1283
@yinanazhou yinanazhou mentioned this issue Feb 3, 2025
Merged
yinanazhou added a commit that referenced this issue Feb 3, 2025
@yinanazhou
feat: add Untoggle All Toggled Syllables MEI action
14006b7 
refs: #1283
@yinanazhou
Copy link
Member

Hi, I've pushed the changes :)

@JoyfulGen
Copy link
Contributor Author

Amazing!! I've tried it out and it looks like it untoggles syllables, but it doesn't give the second linked syllable a syl element. I can add the syl thanks to your new fix, but it would be more efficient if it just appeared automatically like it does when I use the "Toggle linked syllables" button. Would that be possible?

@yinanazhou
Copy link
Member

Right. Sorry about that!

yinanazhou added a commit that referenced this issue Feb 4, 2025
@yinanazhou
fix: add empty syl for follows syllable
4fb1ef2 
refs: #1283 (comment)
@yinanazhou yinanazhou mentioned this issue Feb 4, 2025
Merged
yinanazhou added a commit that referenced this issue Feb 4, 2025
@yinanazhou
fix: add empty syl for follows syllable
65c1744 
refs: #1283 (comment)
@yinanazhou
Copy link
Member

The fix is up :)

@JoyfulGen
Copy link
Contributor Author

It's gorgeous!! That'll be so useful, thank you very much. I'll close the issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yinanazhou @JoyfulGen