Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for X509 mutual authentication/authorization #4

Merged
merged 2 commits into from
May 18, 2021

Conversation

amithkk
Copy link
Member

@amithkk amithkk commented May 17, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • helm install --dry-run has been performed locally
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Addresses feature request for X509 mutual authentication/authorization (Resolves #3)

What is the new behavior?

New configuration parameters added to allow kube-native use of the x509 mutual authentication/authorization provided by the database-agent and mongodb-audit-watcher

In addition this PR contains the following changes:

  • Fix for PORT not applying to database agent
  • Remove explicit storage class and allow default behaviour

Does this introduce a breaking change?

  • Yes
  • No

There are no breaking changes as these features are only enabled if <service>.mongoTLS.enabled is set to true (which is not the default behaviour)

Other information

All the environment variables that are used to control the new functionality are documented in the READMEs for each chart

@amithkk amithkk added the enhancement New feature or request label May 17, 2021
@amithkk amithkk added this to the 1.0.2 milestone May 17, 2021
@amithkk amithkk requested a review from a team May 17, 2021 16:18
@amithkk amithkk self-assigned this May 17, 2021
@amithkk amithkk merged commit 4207213 into master May 18, 2021
@amithkk amithkk deleted the feature/3-add-x509-configuration branch May 18, 2021 05:40
@amithkk amithkk modified the milestones: 1.0.2, 1.1.0 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuring x509 authentication on mongodb related helm charts
3 participants