Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Spawns on the same height (AutoSetup) #101

Open
wants to merge 9 commits into
base: dev-v4
Choose a base branch
from

Conversation

Kalibrier
Copy link
Contributor

Should generate a round grass circle and set all of the spawns on the same height

@Kalibrier
Copy link
Contributor Author

Although, this might also make an island. - may need to adjust to replace every air block under the circle to dirt

@Almighty-Satan
Copy link
Collaborator

Almighty-Satan commented Dec 29, 2024

Could you add some explanation as to what the motivation behind this feature is? Why is this required and why is it better than the current behavior? Do you have any in-game screenshots of the resulting spawns?

@Kalibrier
Copy link
Contributor Author

Could you add some explanation as to what the motivation behind this feature is? Why is this required and why is it better than the current behavior? Do you have any in-game screenshots of the resulting spawns?

In the original Varo, I think all of the spawns were on the same height which would make the plugin more authentic

@Almighty-Satan
Copy link
Collaborator

In the original Varo, I think all of the spawns were on the same height which would make the plugin more authentic

Seems like a good feature, but it should be added as an optional config setting, as I assume most users would want to keep using the current behavior

@Almighty-Satan
Copy link
Collaborator

You should also probably use different branches for different PRs, as this PR now also contains the changes from #100

@Almighty-Satan Almighty-Satan added the enhancement New feature or request label Dec 29, 2024
@Kalibrier
Copy link
Contributor Author

You should also probably use different branches for different PRs, as this PR now also contains the changes from #100

Oh yeah, didn't notice that, sorry!

@Almighty-Satan
Copy link
Collaborator

Seems like a good feature, but it should be added as an optional config setting, as I assume most users would want to keep using the current behavior

You can add a config entry here and then only use the new behavior if ConfigSetting.YOUR_ENTRY.getValueAsBoolean() is true.

In case that's too much work for you or if you're unsure how to do it, I can do it myself when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants