Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Network Port Status with listening ports from the processes #1268

Open
1 task done
BroOtti opened this issue Dec 6, 2024 · 3 comments
Open
1 task done

Extend Network Port Status with listening ports from the processes #1268

BroOtti opened this issue Dec 6, 2024 · 3 comments
Labels
enhancement New features or enhancements to existing ones

Comments

@BroOtti
Copy link

BroOtti commented Dec 6, 2024

I confirm that

  • I have searched for an existing feature request matching the description.

Feature Description

Currently, the Network Port Status section of the status tab of an instance only shows the assigned ports AMP is aware of. It would be nice if AMP would check if the main process or any child process is listening on additional ports.

As an example, I created a Wreckfest server(Linux/Docker) which shows the following Network Port Status:
image
Checking with ss -tulnp | grep wineserver shows the server is listening on the following ports:

udp   UNCONN 0      0            0.0.0.0:27017      0.0.0.0:*    users:(("Wreckfest_x64.e",pid=42380,fd=60),("wineserver64",pid=42322,fd=326))
udp   UNCONN 0      0            0.0.0.0:33540      0.0.0.0:*    users:(("wineserver64",pid=42322,fd=325))
udp   UNCONN 0      0                  *:27016            *:*    users:(("Wreckfest_x64.e",pid=42380,fd=76),("wineserver64",pid=42322,fd=345))

If AMP would display the mismatched port 27017 in this case, it would help to diagnose the problem faster. Especially for users aren't that experienced with servers, but also for supporters trying to help another user.

@BroOtti BroOtti added the enhancement New features or enhancements to existing ones label Dec 6, 2024
@Greelan
Copy link
Contributor

Greelan commented Dec 6, 2024

Wreckfest sucks with its port handling. I'm not sure a crappy server should be the prompt for this

@BroOtti
Copy link
Author

BroOtti commented Dec 6, 2024

It would also help if an update adds additional ports or changes port handling.
Also, it could help people, if they add a plugin for minecraft which listens on a port, and they forgot to add the port to AMP :D
Tbh, I also don't see a need for myself of this feature, but it could help other people.

@IceOfWraith
Copy link
Collaborator

I'm on board with notifying if a random port is opened by the app and not tracked by AMP. But I don't know the best way to alert the user. I'm thinking it might be best to include it in the logs but not in the UI. That way, when someone is helping troubleshoot they can catch that a new port was added. I worry if it's in the UI directly facing users they might get confused and some of the ports may be useless and false scares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or enhancements to existing ones
Projects
None yet
Development

No branches or pull requests

3 participants