Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mustache and logging code shouldn't be static #361

Open
The-EDev opened this issue Mar 18, 2022 · 0 comments
Open

Mustache and logging code shouldn't be static #361

The-EDev opened this issue Mar 18, 2022 · 0 comments
Labels
feature Code based project improvement

Comments

@The-EDev
Copy link
Member

Variables like CROW_LOG_LEVEL and get_template_base_directory_ref() aren't tied to an app, which is an issue in case a user wants to run 2 or more apps with different settings for the logger or template engine.
@The-EDev The-EDev added the feature Code based project improvement label Mar 18, 2022
@The-EDev The-EDev added this to the v1.1 milestone Mar 18, 2022
@The-EDev The-EDev mentioned this issue Mar 18, 2022
Closed
@gittiver gittiver removed this from the v1.2 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Code based project improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gittiver @The-EDev