Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for keep-alive header #257

Open
The-EDev opened this issue Oct 26, 2021 · 0 comments
Open

Support for keep-alive header #257

The-EDev opened this issue Oct 26, 2021 · 0 comments
Labels
feature Code based project improvement

Comments

@The-EDev
Copy link
Member

While Crow supports Connection: Keep-Alive, it ignores the optional keep-alive header which defines parameters for the persistent connection.
The specification says that there are no parameters defined. But MDN mentions 2: timeout and max.

Crow currently uses the default server timeout for keep-alive connections. and outside of debug mode, I don't believe it does any tracking of the number of requests. Therefore a full implementation will require modifying the dumb_timer_queue to support custom times, and adding request and per-connection request tracking.

A partial implementation can have Crow send its own keep-alive header while ignoring the ones potentially sent by the client.

@The-EDev The-EDev added the feature Code based project improvement label Oct 26, 2021
luca-schlecker added a commit that referenced this issue Nov 19, 2021
fixes #264, lays ground for #273 and #257.

Signed-off-by: Luca Schlecker <[email protected]>
luca-schlecker added a commit that referenced this issue Nov 19, 2021
fixes #264, lays ground for #273 and #257.

Signed-off-by: Luca Schlecker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Code based project improvement
Projects
None yet
Development

No branches or pull requests

1 participant