Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up redux code #24

Open
bmcd opened this issue Nov 13, 2019 · 0 comments
Open

Clean up redux code #24

bmcd opened this issue Nov 13, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bmcd
Copy link
Contributor

bmcd commented Nov 13, 2019 •
edited by Krish1979
Loading

The app started out using React.useContext() instead of redux, but later was migrated over. So the reducers and actions are all in one big file each. This could be split up and organized better. Also we probably aren't following all the current best practices for react/redux.

┆Issue is synchronized with this Jira Task
@bmcd bmcd added enhancement New feature or request help wanted Extra attention is needed labels Nov 13, 2019
bmcd added a commit that referenced this issue Nov 14, 2019
@bmcd
#24 Splits up reducers/actions into separate files, fixes method call…
5f53f64 
… error bug

Errors in method calls weren't re-enabling the contracts call buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmcd