Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on System Identity by default. #592

Closed
wants to merge 5 commits into from
Closed

Turn on System Identity by default. #592

wants to merge 5 commits into from

Conversation

isaacabraham
Copy link
Member

@isaacabraham isaacabraham commented Mar 22, 2021 •
edited
Loading

This PR closes #591

The changes in this PR are as follows:

  • Turn on System Identity by default for Web App, Functions, Container Service and Container Group
  • Parameterise system_identity keyword (breaking change).
  • Add system_identity keyword for Container Service.

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

@isaacabraham isaacabraham marked this pull request as ready for review March 27, 2021 18:31
@isaacabraham isaacabraham requested a review from ninjarobot March 27, 2021 18:31
ninjarobot
ninjarobot reviewed Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@ninjarobot ninjarobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code all looks great, but what do you think of specifying the default for resources in the arm builder so users can "opt in" on this for everything in a given deployment and it won't just start doing this automatically after a package upgrade? It would save them from having to add it on each resource, but also not change their behavior just by upgrading.

@isaacabraham
Copy link
Member Author

I think we could support threading some arbitrary state through all builders by changing the IBuilder interface.

@isaacabraham isaacabraham mentioned this pull request Apr 26, 2021
Open
@isaacabraham
Copy link
Member Author

@ninjarobot I think given the limits on identities, this PR should be closed - otherwise I can see those identity limits being hit without notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninjarobot ninjarobot ninjarobot left review comments

Assignees
No one assigned
Labels
arm-resource discussion on-hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn on System Identity on App Service and Functions by default
3 participants
@isaacabraham @ninjarobot @martinbryant