Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are rollbacks supported in any capacity? #462

Open
NatElkins opened this issue Nov 15, 2020 · 3 comments
Open

Are rollbacks supported in any capacity? #462

NatElkins opened this issue Nov 15, 2020 · 3 comments
Labels
enhancement New feature or request framework

Comments

@NatElkins
Copy link

I am using Farmer via the SAFE stack template. When I first ran the deploy target, one part of it failed because the app name I had chosen was already taken. It looked something like this:

image

I just changed the name and it solved the issue. But the application insights and app service plans still had been created (using the previous name) and I had to go in and delete them. I think it's preferable, if possible, to have the resources fail/rollback/be deleted if any part of the deployment fails. Is such a thing possible?

@isaacabraham
Copy link
Member

@NatElkins That's kind of an ARM thing - maybe have a look at the deployment behaviour of ARM and see if there's an option for this, if there is, we could bake that in.

@NatElkins
Copy link
Author

@isaacabraham isaacabraham added enhancement New feature or request framework labels Dec 12, 2020
@isaacabraham
Copy link
Member

@NatElkins we could certainly add this. In the future, we're going to probably redesign the deployment API anyway (there's already an experimental branch) and this could be part of that i.e. supply an "auto rollback" argument.

For now, we could add a simple "rollback" command which you could manually call based on the result of the call to deploy e.g.

match template |> Deploy.execute "my-rg" [] with
| Ok _ ->
    "happy days!"
| Error _ ->
   template |> Deploy.rollback "my-rg"
   "failed - rolled back"

What do you think?

@isaacabraham isaacabraham added this to the 1.4 milestone Dec 12, 2020
@isaacabraham isaacabraham removed this from the 1.4 milestone Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request framework
Projects
None yet
Development

No branches or pull requests

2 participants