Issue 225 #254
Open
Issue 225 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit tests correctly write raw or json formats to files
|
Looks good! Could you please fix lint and post some screenshots of how the logs look like with the new config? |
JSON format, writing both to stdout + file
RAW format, writing both to stdout + file
DEFAULT format, writing only to stdout
note the other permutations work but aren't pictured:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more flexibility when logging to support writing to both stdout and a file or either. Also the user can choose whether they want the current default formatting, a raw formatting, or JSON formatting according to the requested formats from #225.
Two new fields to the config:
closes #225