Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't link output to input when the output is a subset of the input #2536

Open
RagingCub opened this issue Feb 12, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@RagingCub
Copy link

RagingCub commented Feb 12, 2025

Frontend Version

v1.8.14

Expected Behavior

When linking KSampler Config (rgthree)'s scheduler to FaceDetailer (impact-pack)'s scheduler, the link appears.

Actual Behavior

The link refuses to appear

Steps to Reproduce

the versions in cause are rgtree: v.1.0.0, and impact-pack: 8.8.1

with rgthree and impact-pack installed:

  1. add a KSampler Config (rgthree) node;
  2. add a FaceDetailer node;
  3. on the FaceDetailer, right click the scheduler widget to convert to an input;
  4. try to link the scheduler on both nodes.

Debug Logs

not required

Browser Logs

not required

Setting JSON

not required

What browsers do you use to access the UI ?

Mozilla Firefox

Other

This is probably due to the validation that the input types must match exactly.
From the impact-pack's repo, they extended the scheduler definition, causing a mismatch.
However, since all the values of the type are included in the input type, it should still be valid to link the subset to the superset.

┆Issue is synchronized with this Notion page by Unito

@RagingCub RagingCub added the Potential Bug Untriaged bug label Feb 12, 2025
@huchenlei huchenlei added bug Something isn't working and removed Potential Bug Untriaged bug labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants