Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit dialog has unwanted grey dot icons and wrong text alignment #10841

Open
eszkadev opened this issue Jan 2, 2025 · 4 comments
Open

Audit dialog has unwanted grey dot icons and wrong text alignment #10841

eszkadev opened this issue Jan 2, 2025 · 4 comments
Assignees
Labels
24.04 dialog Issues with dialogs regression Something that was working in the past, but not now UX

Comments

@eszkadev
Copy link
Contributor

eszkadev commented Jan 2, 2025

Describe the Bug

After treeview rework CSS in Audit Dialog produces additional icons.

Steps to Reproduce

  1. Go to Help -> Server Audit

Expected Behavior

Only first column has grey dot icon

Actual Behavior

All columns hav grey dot icon

Screenshots

auditicons

@eszkadev eszkadev added bug Something isn't working regression Something that was working in the past, but not now UX dialog Issues with dialogs 24.04 labels Jan 2, 2025
@banobepascal
Copy link

@eszkadev I think these dots were mean't to be up/down icons since "Status" and "Help" are sorting options.
Maybe when we are to also remove the sorting experience then the right approach would be to remove the dot icons.

Whats your take on the above?

cc @pedropintosilva

@Ezinnem Ezinnem removed the bug Something isn't working label Jan 4, 2025
@Ezinnem
Copy link
Member

Ezinnem commented Jan 4, 2025

Seen on:
COOLWSD version: 24.04.10.1(git hash: 3799c09 (E))
LOKit version: Collabora Office 24.04.10.1(git hash: 565bfb5)
Served by: Debian GNU/Linux 12 (bookworm)
Server ID: ce791f39
WOPI host: nextcloud 30.0.0.14 - richdocuments 8.5.3

image

OK in:
COOLWSD version: 24.04.8.1(git hash: 8475197 (E))
LOKit version: Collabora Office 24.04.8.1(git hash: 5c1b808)
Served by: Debian GNU/Linux 12 (bookworm)
Server ID: 07ed0e59
WOPI host: nextcloud 30.0.0.14 - richdocuments 8.5.3

image

@pedropintosilva
Copy link
Contributor

Thanks @Ezinnem , yes we should at least in a first step aim to reach that old OK status:

image

However there are a couple of problems that we should try to fix:

  1. Ideally the status icon would be part of the Status column and thus no gray icon as heading would be needed.
  • But for that to happen the treeview widget needs to be improved/expanded so it allows more than one element per column (icon + text)
  1. All text should be left aligned
  2. "No issues found" is also quite out of place maybe we could move it to other place (tile bar) or at the end with different format , what do you think @banobepascal
  3. It would be also nice to have that summary even when we have issues. Example: "2 issues found"

@pedropintosilva
Copy link
Contributor

up/down icons

As an additional improvement we could add those icons into the treeview (for all cases or sorting is possible)

@pedropintosilva pedropintosilva changed the title Audit dialog has unwanted grey dot icons Audit dialog has unwanted grey dot icons and wrong text alignment Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.04 dialog Issues with dialogs regression Something that was working in the past, but not now UX
Projects
Status: No status
Development

No branches or pull requests

4 participants