From bc43679a32bdbe686d3293225291c70c438fc685 Mon Sep 17 00:00:00 2001 From: Kriti Sapra Date: Tue, 20 Jul 2021 09:59:46 +0000 Subject: [PATCH] Added clean-css to minify CSS on release build Bug: 1106746 Change-Id: I4165bb4fa30564dc3b8eff942f6cb341a6e31ffb Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3037550 Commit-Queue: Kriti Sapra Reviewed-by: Tim van der Lippe Reviewed-by: Jack Franklin --- scripts/build/generate_css_js_files.js | 7 +++++-- scripts/build/ninja/generate_css.gni | 4 ++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/build/generate_css_js_files.js b/scripts/build/generate_css_js_files.js index 0f1232ef2ca..ea4263da8aa 100644 --- a/scripts/build/generate_css_js_files.js +++ b/scripts/build/generate_css_js_files.js @@ -3,10 +3,13 @@ // found in the LICENSE file. const fs = require('fs'); const path = require('path'); -const [, , targetName, srcDir, targetGenDir, files] = process.argv; +const CleanCSS = require('clean-css'); +const [, , isDebugString, targetName, srcDir, targetGenDir, files] = process.argv; const filenames = files.split(','); const configFiles = []; +const cleanCSS = new CleanCSS(); +const isDebug = isDebugString === 'true'; for (const fileName of filenames) { const output = fs.readFileSync(path.join(srcDir, fileName), {encoding: 'utf8', flag: 'r'}); @@ -18,7 +21,7 @@ for (const fileName of filenames) { // found in the LICENSE file. const styles = new CSSStyleSheet(); styles.replaceSync( -\`${output} +\`${isDebug ? output : cleanCSS.minify(output).styles} /*# sourceURL=${fileName} */ \`); export default styles; diff --git a/scripts/build/ninja/generate_css.gni b/scripts/build/ninja/generate_css.gni index 14f411bbada..9c581a636f0 100644 --- a/scripts/build/ninja/generate_css.gni +++ b/scripts/build/ninja/generate_css.gni @@ -13,7 +13,11 @@ template("generate_css") { _src = rebase_path(".", root_build_dir) _dest = rebase_path(target_gen_dir, root_build_dir) + inputs += + [ devtools_location_prepend + "node_modules/clean-css/package.json" ] + args = [ + "$is_debug", target_name, _src, _dest,