Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Search only returns one result if the search term appears multiple times in the same line #1497

Closed
tom-ludwig opened this issue Nov 30, 2023 · 3 comments
Labels
bug Something isn't working triage needed

Comments

@tom-ludwig
Copy link
Member

Description

The current search implementation is limiting results to just one when the search term appears multiple times in the same line.

To Reproduce

  1. Input a search term that appears multiple times within the same line.
  2. Observe that the search results currently display only one instance.

Expected Behavior

In Xcode, the same line is currently presented as two separate results, each highlighting different words.

Version Information

CodeEdit: [e.g. 0.0.x-alpha.y]
macOS: [e.g. 13.2.1]
Xcode: [e.g. 14.2]

Additional Context

No response

Screenshots

Screenshot 2023-11-30 at 11 03 02 AM

Xcode on the Left; CE on the right

@tom-ludwig tom-ludwig added the bug Something isn't working label Nov 30, 2023
@deepal15
Copy link

deepal15 commented Dec 3, 2023

It is working expected. CE Screen shot from latest build. Am I missing anything?
Screenshot 2023-12-03 at 10 06 59 PM

@tom-ludwig
Copy link
Member Author

@deepal15 Please take a closer look at the words that should've been in capital letters. For instance Hello World is displayed as hello world. This will be fixed with the search indexing PR tho.

@tom-ludwig
Copy link
Member Author

@deepal15, terribly sorry, I've rather muddled up this issue with another one. And you're spot on, of course.

@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage needed
Projects
Status: 🏁 Complete
Development

No branches or pull requests

2 participants