Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] sign in with google oauth2 #4

Closed
3 tasks done
dusdjhyeon opened this issue Oct 17, 2023 · 0 comments · Fixed by #15
Closed
3 tasks done

[Feat] sign in with google oauth2 #4

dusdjhyeon opened this issue Oct 17, 2023 · 0 comments · Fixed by #15
Assignees
Labels
enhancement New feature or request

Comments

@dusdjhyeon
Copy link
Contributor

dusdjhyeon commented Oct 17, 2023

🚀 Feature Request

  • modify user structure(it already exists)
  • add login api w/google oauth
  • verify email pattern (khu.ac.kr)

📎 Additional context

  • I will modify jwt code after creating login logic
@dusdjhyeon dusdjhyeon added the enhancement New feature or request label Oct 17, 2023
@dusdjhyeon dusdjhyeon self-assigned this Oct 17, 2023
@dusdjhyeon dusdjhyeon changed the title [Feat] login with google oauth2 [Feat] sign in with google oauth2 Oct 17, 2023
@dusdjhyeon dusdjhyeon moved this from Todo to In Progress in KHU Market BE Oct 17, 2023
@dusdjhyeon dusdjhyeon linked a pull request Nov 19, 2023 that will close this issue
@dusdjhyeon dusdjhyeon moved this from In Progress to Done in KHU Market BE Nov 19, 2023
dusdjhyeon added a commit that referenced this issue Nov 23, 2023
## Description

- You can login with google oauth.
- You can receive current user's email through the access token provided
by google oauth.
- Only KyungHee Univ email account users will be saved in mysql.

## Problems
- The validity of the access token (bear type) provided by Google oauth
is only 1 hour.
- After login, you will be redirected to the callback url. 
- We need to redirect to two different pages depending on whether the
user has previously signed up or not

## Additional
After login response : {"info": {"access_token:"~~~~",
"token_type":"bearer"}, "member": bool}
If member key = true : The current user is already a subscribed user.

## Related Issue

close #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant