Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] update market price #36

Closed
2 tasks done
nahyun0121 opened this issue Dec 2, 2023 · 0 comments · Fixed by #43
Closed
2 tasks done

[Feat] update market price #36

nahyun0121 opened this issue Dec 2, 2023 · 0 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@nahyun0121
Copy link
Member

nahyun0121 commented Dec 2, 2023

🚀 Feature Request

  • update market price
  • only when a higher price is offered than the current one

📎 Additional context

@nahyun0121 nahyun0121 added the enhancement New feature or request label Dec 2, 2023
@nahyun0121 nahyun0121 self-assigned this Dec 2, 2023
@nahyun0121 nahyun0121 linked a pull request Dec 3, 2023 that will close this issue
nahyun0121 added a commit that referenced this issue Dec 3, 2023
## Description
- update market price
 only when a higher price is offered than the current on
- make bid price Pydantic model
<!-- Add a more detailed description of the changes if needed. -->

## Related Issue
close #36 
<!-- If your PR refers to a related issue, link it here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant