From 0.G stable to latest experimental, every character loses their "mutation" hair. Everyone is Bald.

[LucioMagno]

Describe the bug

All characters lost their hair "mutation" and now they are bald. something to do with the refactor of how hair works maybe?

Attach save file

N/A

Steps to reproduce

1. make a player with hair in 0.G
2. Update the game to latest experimental.
3. Alopecia ensues.

Expected behavior

I expected that every npc kept their hair.

Screenshots

No response

Versions and configuration

• Windows 10
• English
• "dda", "no_npc_food", "personal_portal_storms", "no_fungal_growth", "package_bionic_professions", "mindovermatter", "railroads".

Additional context

No response

[RedMisao]

The hair json styling was changed at some point during 0.G experimentals, before they were individual mutations for each hair style and color iirc. They were changed into hairstyles containing hair colors (as variants).
Maybe the obsoletion process didn't or can't visually "port" the old appearances to the new ones, if this is what you mean by refactor.

[harakka]

or can't visually "port" the old appearances to the new ones

Not breaking hair from stable was a requirement for that PR to be accepted, so this definitely should be working.

[ZhilkinSerg]

Is it true for all tilesets in your game version? It is possible that only some tilesets are affected - see I-am-Erk/CDDA-Tilesets#2237

[anoobindisguise]

or can't visually "port" the old appearances to the new ones

Not breaking hair from stable was a requirement for that PR to be accepted, so this definitely should be working.

All of the classic hairstyles no longer exist, creating an error on game load followed by everyone being bald. Only thr "new style" hair muts are in the game now.

[harakka]

ping @MNG-cataclysm

[MNG-cataclysm]

This is not good. I guess migrating the mutations could fix this? I'll experiment today.

EDIT: Come to think of it, I didn't change the mutation IDs for hair in my second PR, so I don't know why that would cause the disappearance of traits. This was probably caused by some earlier change of JSON style to hair, like @RedMisao mentioned, when individual color was ported from full mutations to variants.

[LucioMagno]

I can think of a simple solution to this: keep the old hair style format in-game but obscured. and only apply the new format to new npcs.

[anoobindisguise]

Yeah tilesets are looking for the name of the mutation, so it's probably important to just keep these legacy mutations in a separate file and make them not be choosable. It doesn't do much harm, even with a migration people may have to manually edit 3rd party tilesets.

[harakka]

I guess it was this that broke it? Can anyone confirm #70017
Nope, definitely not this.

[harakka]

/confirm
Tested going from 0.G to 2dbf12c. Bug reproduces on both Ultica and MSX+
5a22c1c is good
f255964 is good, so not in danger of being a release blocker for 0.H

Repro save: New City-trimmed.tar.gz
Seems to depend on exact hairstyle?

[Night-Pryanik]

Can't confirm on 0.G-12522.

Closing until reconfirmed.