Suppress Errors Optionally #33
Conversation
* Lets some errors bubble up so we can handle them if needed
| try { | ||
| await client.issues.addLabels(labelData); | ||
| } catch (error) { | ||
| core.setFailed(error.message); | ||
| process.exit(1); | ||
| } |
There was a problem hiding this comment.
any particular reason on removing this try...catch block?
There was a problem hiding this comment.
the thought was that these errors are already caught in main, and since we added more specific error handling in there it was nice to have the errors bubble up and be handled in main.
|
@Anks @loftykhanna can probably merge this PR |
|
There probably isn't a way for us to test these PRs anymore since we do not use Pivotal anymore. Suggestions? |
|
@hammerdr Thanks for raising this PR! 👋🏽 WRT the comment above, we would really appreciate if you could post a few screenshots after enabling/disabling this option on one of your test repos and showing the description maybe? Feel free to blur out any confidential information from your company. |
|
example: |
cc @pturley
Resolves #32