-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: whatsapp desktop app #838
Conversation
Perhaps it would be better to call the entry 'ZapZap', with the description specifying that it's a client for WhatsApp. |
core/tabs/applications-setup/communication-apps/whatsapp-setup.sh
Outdated
Show resolved
Hide resolved
Co-authored-by: JEEVITHA KANNAN K S <[email protected]>
Try to keep consistency with other scripts. This is not a big deal but linutil uses 4 space or tab instead of 2 spaces. |
Okay, I think it has to do with my lazyvim. I'll make sure this won't happen again |
I agree. |
okay I'll change it
|
As per @Ilj3954 and @adamperkowski request, I'm changing both option and script name to zapzap (which was the original name of the app)
core/tabs/applications-setup/communication-apps/zapzap-setup.sh
Outdated
Show resolved
Hide resolved
core/tabs/applications-setup/communication-apps/zapzap-setup.sh
Outdated
Show resolved
Hide resolved
core/tabs/applications-setup/communication-apps/zapzap-setup.sh
Outdated
Show resolved
Hide resolved
core/tabs/applications-setup/communication-apps/zapzap-setup.sh
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Hey @adamperkowski, can you help me clearing this shell formatting check? It's returning error code 1 |
Run |
core/tabs/applications-setup/communication-apps/zapzap-setup.sh
Outdated
Show resolved
Hide resolved
[[data.entries]] | ||
name = "Zoom" | ||
description = "Zoom is a widely-used video conferencing platform that allows users to host virtual meetings, webinars, and online collaboration with features like screen sharing and recording." | ||
script = "communication-apps/zoom-setup.sh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[data.entries]] | |
name = "Zoom" | |
description = "Zoom is a widely-used video conferencing platform that allows users to host virtual meetings, webinars, and online collaboration with features like screen sharing and recording." | |
script = "communication-apps/zoom-setup.sh" |
Co-authored-by: Jeevitha Kannan K S <[email protected]>
Co-authored-by: Jeevitha Kannan K S <[email protected]>
Type of Change
Description
ZapZap is an open source
WhatsApp
desktop client. This script allows to install ZapZap in your systemTesting
For arch, I've tested on my own system. In case of other distro's, I've set Flatpak as default option.
Checklist