Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: whatsapp desktop app #838

Merged
merged 13 commits into from
Nov 7, 2024
Merged

Conversation

harshv5094
Copy link

@harshv5094 harshv5094 commented Oct 16, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

ZapZap is an open source WhatsApp desktop client. This script allows to install ZapZap in your system

Testing

For arch, I've tested on my own system. In case of other distro's, I've set Flatpak as default option.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@harshv5094 harshv5094 changed the title feat(whatsapp): add whatsapp desktop client for linux feat(whatsapp): add whatsapp desktop app for linux Oct 16, 2024
@lj3954
Copy link
Contributor

lj3954 commented Oct 16, 2024

Perhaps it would be better to call the entry 'ZapZap', with the description specifying that it's a client for WhatsApp.

@jeevithakannan2
Copy link
Contributor

jeevithakannan2 commented Oct 20, 2024

Try to keep consistency with other scripts. This is not a big deal but linutil uses 4 space or tab instead of 2 spaces.

@harshv5094
Copy link
Author

harshv5094 commented Oct 21, 2024

Try to keep consistency with other scripts. This is not a big deal but linutil uses 4 space or tab instead of 2 spaces.

Okay, I think it has to do with my lazyvim. I'll make sure this won't happen again

@adamperkowski adamperkowski changed the title feat(whatsapp): add whatsapp desktop app for linux feat: whatsapp desktop app Oct 25, 2024
@adamperkowski
Copy link
Collaborator

Perhaps it would be better to call the entry 'ZapZap', with the description specifying that it's a client for WhatsApp.

I agree.

@adamperkowski adamperkowski added the enhancement New feature or request label Oct 25, 2024
@harshv5094
Copy link
Author

okay I'll change it

Perhaps it would be better to call the entry 'ZapZap', with the description specifying that it's a client for WhatsApp.

I agree.

As per @Ilj3954 and @adamperkowski request, I'm changing both option and
script name to zapzap (which was the original name of the app)
@harshv5094
Copy link
Author

Hey @adamperkowski, can you help me clearing this shell formatting check? It's returning error code 1

@jeevithakannan2
Copy link
Contributor

jeevithakannan2 commented Nov 6, 2024

Run shfmt -i 4 -ci -w path/to/file.sh

core/tabs/applications-setup/tab_data.toml Outdated Show resolved Hide resolved
Comment on lines +94 to +98
[[data.entries]]
name = "Zoom"
description = "Zoom is a widely-used video conferencing platform that allows users to host virtual meetings, webinars, and online collaboration with features like screen sharing and recording."
script = "communication-apps/zoom-setup.sh"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[data.entries]]
name = "Zoom"
description = "Zoom is a widely-used video conferencing platform that allows users to host virtual meetings, webinars, and online collaboration with features like screen sharing and recording."
script = "communication-apps/zoom-setup.sh"

@ChrisTitusTech ChrisTitusTech merged commit 51e2cbd into ChrisTitusTech:main Nov 7, 2024
3 of 4 checks passed
@harshv5094 harshv5094 deleted the whatsapp branch November 8, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants