fix: fedora timeshift #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better if you also disable firewall setup for fedora as well, as fedora uses Firewalld out of the box and fedora also has rules for Workstation set out of the box, so there is really no need to set up ufw. Also, it might not work properly if both of them are on at the same time. |
AkkhilCodingHub
approved these changes
Oct 8, 2024
jeevithakannan2
approved these changes
Oct 20, 2024
adamperkowski
approved these changes
Oct 30, 2024
ChrisTitusTech
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisTitusTech this does not make timeshift fedora only, this only makes it so timeshift cannot be seen by fedora users, please look at #773 for more information
closes #773
Type of Change
Description
since fedora does not support the use of timeshift, it should be excluded.
more information is in this issue #773
testing
Tested using a fedora container and my main system (Arch Linux), and the precondition works flawlessly