Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quilt support? #751

Open
Shad0wolf0 opened this issue Jul 3, 2022 · 4 comments · May be fixed by #988
Open

Quilt support? #751

Shad0wolf0 opened this issue Jul 3, 2022 · 4 comments · May be fixed by #988

Comments

@Shad0wolf0
Copy link

Will you add support for Quilt in the future? Currently, it crashes trying to use it and the normal Fabric loader works fine.

@y2k04
Copy link

y2k04 commented Jul 4, 2022

Can confirm. Here is the log: https://pastebin.com/SmUVU3Nz

@topia
Copy link

topia commented Jul 4, 2022

Caused by: java.lang.ClassNotFoundException: net.fabricmc.loader.util.version.VersionParsingException

This stack trace shows that the quilt-loader's fabric mod compatibility layer doesn't provide the necessary class for optifabric.
I think that the quilt-loader should provide that class.

But although if it's implemented, optifabric has a fabric API compatibility mixin (patching to fabric API), so developing the patch to qsl/quilted-fabric-api is also necessary. it's not an easy task, I think.

@jplusc
Copy link

jplusc commented Jul 12, 2022

Just copying over my log and such from a diff issue I opened about this before I saw this one : )

....

** Exception while loading entries for entrypoint 'mm:early_risers' **

Is there anything that can be done to make optifabric more compatible with quilt as other fabric mods seem to do well on quilt,

or is this something that quilt needs to do to make quilt more compatible with your mod?

I'd really like to keep optifine over sodium and your mod has made that possible for me for a long time.

thanks for all your work!!

[11:15:26] [main/ERROR]: Error encountered during mixin config postInit step 'mixins.mm.json' from mod 'mm': Exception while loading entries for entrypoint 'mm:early_risers' provided by 'optifabric'
org.quiltmc.loader.impl.entrypoint.QuiltEntrypointException: Exception while loading entries for entrypoint 'mm:early_risers' provided by 'optifabric'
	at org.quiltmc.loader.impl.entrypoint.EntrypointStorage.getEntrypoints(EntrypointStorage.java:177) ~[quilt-loader-0.17.0.jar:?]
	at org.quiltmc.loader.impl.QuiltLoaderImpl.getEntrypoints(QuiltLoaderImpl.java:364) ~[quilt-loader-0.17.0.jar:?]
	at org.quiltmc.loader.api.QuiltLoader.getEntrypoints(QuiltLoader.java:51) ~[quilt-loader-0.17.0.jar:?]
	at net.fabricmc.loader.impl.FabricLoaderImpl.getEntrypoints(FabricLoaderImpl.java:50) ~[quilt-loader-0.17.0.jar:?]
	at com.chocohead.mm.Plugin.getMixins(Plugin.java:340) ~[Fabric-ASM-v2.3.jar-8706edde-901e-4a1e-938d-d7679776b24a-nested.jar:?]

full log:
https://paste.ee/p/GEoY8 (expired new link below)
https://paste.denizenscript.com/View/99181

@leo60228
Copy link

Quilt doesn't attempt compatibility with internal APIs. In general, mods are heavily discouraged from using them, even on Fabric, and they could break at any time.

@XXMA16 XXMA16 linked a pull request Mar 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants