Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Goldbeter 1991 Srn Model #3

Open
3 of 7 tasks
kwabenantim opened this issue Nov 8, 2023 · 2 comments · May be fixed by #4
Open
3 of 7 tasks

Convert Goldbeter 1991 Srn Model #3

kwabenantim opened this issue Nov 8, 2023 · 2 comments · May be fixed by #4
Assignees
Labels
enhancement New feature or request

Comments

@kwabenantim
Copy link
Member

kwabenantim commented Nov 8, 2023

Summary
Fix code generation with lessons learned from Goldbeter 1991 sbml:

  • Fix variable names. Names can have spaces so perhaps use ids instead, or do some name mangling.
  • Fix generated number of ODE parameters (for Goldbeter, it was 5 rather than 3).
  • Add methods to get state variables. Use variable names for clarity.
  • Allow solver selection in command line e.g. RungeKutta4IvpOdeSolver or CVODE.
  • Consider generating custom Srn model separately to replace template.
  • Allow setting solver SetDt(0.1) in command line.
  • Allow customizing timescale of results?

Related Issues

@kwabenantim kwabenantim added the bug Something isn't working label Nov 8, 2023
@kwabenantim kwabenantim self-assigned this Nov 8, 2023
@mirams
Copy link
Member

mirams commented Nov 8, 2023

For the solver selection, it is probably just "chaste solvers" or "CVODE", the only reason these need different generated code to specify an ODE system is that chaste solvers work with std::vector<double> and CVODE/SUNDIALS have their own N_Vector class. (copying what happens in cardiac code, which also generates for either, will be sensible here!)

Specifying what solver to use later on (RungeKutta/ForwardEuler etc.) should be fairly independent of the generated code apart from the CVODE special case.

@kwabenantim
Copy link
Member Author

copying what happens in cardiac code, which also generates for either, will be sensible here!

Thanks @mirams! I think I've found the corresponding codegen:

kwabenantim added a commit that referenced this issue Nov 14, 2023
kwabenantim added a commit that referenced this issue Nov 14, 2023
kwabenantim added a commit that referenced this issue Nov 14, 2023
kwabenantim added a commit that referenced this issue Nov 14, 2023
kwabenantim added a commit that referenced this issue Nov 14, 2023
kwabenantim added a commit that referenced this issue Nov 14, 2023
@kwabenantim kwabenantim linked a pull request Nov 14, 2023 that will close this issue
@kwabenantim kwabenantim linked a pull request Nov 14, 2023 that will close this issue
kwabenantim added a commit that referenced this issue Nov 14, 2023
kwabenantim added a commit that referenced this issue Jan 20, 2025
@kwabenantim kwabenantim changed the title Goldbeter 1991 Fixes Convert Goldbeter 1991 Srn Model Jan 20, 2025
@kwabenantim kwabenantim added enhancement New feature or request and removed bug Something isn't working labels Jan 20, 2025
kwabenantim added a commit that referenced this issue Jan 20, 2025
kwabenantim added a commit that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants