Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with "Available filters" heading in notifications #61

Open
LunaLycan287 opened this issue Nov 20, 2020 · 2 comments
Open

Issue with "Available filters" heading in notifications #61

LunaLycan287 opened this issue Nov 20, 2020 · 2 comments

Comments

@LunaLycan287
Copy link
Contributor

Currently the headline looks like this with the text having no padding to the side:
grafik

In normal github this is okay because it's all white:
grafik

Issue in line 165 "div.border.rounded-1" overwrites the bg color to bg-2 instead of white which is bg-3

My possible solutions:

  1. Change everything to "white" replacement by setting js-notification-search-autocomplete-dropdown to bg-3
    grafik
    Will have to adjust text color of texts & it is not easy to set apart from page background

  2. Change background to bg-2 too
    grafik
    Might have to adjust "Available filters" text color?

  3. Adjust padding
    grafik
    Maybe would have to add rounded borders? Overall doesn't seem nice still

I would personally prefer the 2nd Option. Do you think the text color should also be adjusted? if yes to what?

@CharlieEtienne
Copy link
Owner

Hi @Moonwolf287, second option is great!

@CharlieEtienne
Copy link
Owner

@Moonwolf287 are you going to make a PR for that one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants