Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request comment "See the MS search here" link doesn't include usernames where appropriate #5815

Open
ghost opened this issue Feb 9, 2021 · 2 comments
Labels
area: commands area: git status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it! type: feature request Shinies.

Comments

@ghost
Copy link

ghost commented Feb 9, 2021

Linked to this issue.

The opening comment that SmokeDetector makes on a Pull Request is sometimes incorrect as the "See the MS search here" link doesn't include usernames for watch and blacklist-keyword which can be confusing to reviewers.

The problem is happening on line 117 and 126 of gitmanager.py where &username_is_regex=1 is not set. &or_search=1 must also be set for accurate results.

@ghost
Copy link
Author

ghost commented Feb 9, 2021

I remember trying to fix this and it got rather long/complicated. Maybe a simple note: "Note: This search does not include usernames" is enough.

@stale stale bot added the status: stale label Mar 16, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.

@stale stale bot closed this as completed Mar 19, 2021
@makyen makyen added status: confirmed Confirmed as something that needs working on. and removed status: stale labels Apr 18, 2022
@makyen makyen reopened this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: commands area: git status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it! type: feature request Shinies.
Development

No branches or pull requests

1 participant