Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allspam should also accept a reason argument #4398

Open
gparyani opened this issue Aug 20, 2020 · 4 comments
Open

Allspam should also accept a reason argument #4398

gparyani opened this issue Aug 20, 2020 · 4 comments
Labels
area: commands status: confirmed Confirmed as something that needs working on. type: feature request Shinies.

Comments

@gparyani
Copy link
Contributor

gparyani commented Aug 20, 2020

The !!/report and !!/scan commands accept an optional reason argument, to allow the invoker of the command to add in a reason for why they're scanning or reporting a given post or set of posts, so it's clear to others.

However, the same reason argument isn't accepted for the !!/allspam command. Using that command is no different from going through a user's profile and !!/reporting all their posts, so it doesn't make sense to not also allow supplying a custom reason when using that option.

Can we make the !!/allspam command also take a custom reason, just like the !!/scan and !!/report commands?

@makyen makyen added the status: confirmed Confirmed as something that needs working on. label Sep 17, 2020
@tripleee
Copy link
Member

Would be nice if this could be extended to !!/addblu too, and !!/rmblu I suppose for orthogonality.

@makyen
Copy link
Contributor

makyen commented Sep 29, 2021

@tripleee What would you want us to do with a reason comment on !!/addblu and !!/rmblu? For !!/rmblu, as far as I know, we don't record the reason a user was removed from the user blacklist, at all. Removing them from the user blacklist removes the entry for the user with nothing remaining. For !!/addblu, the only thing currently recorded is the URL of the chat message. Are you wanting to expand that and record more information?

@tripleee
Copy link
Member

My main use case is that it's convenient to provide a rationale in the chat message itself, in case somebody would search for it. In fact, I tried to do that earlier today, and was mildly miffed that this command worked differently from e.g. !!/report. But I agree that we should probably have a more disciplined treatment of this information if indeed we allow users to submit it.

@makyen
Copy link
Contributor

makyen commented Sep 29, 2021

OK. Please create a separate issue for those commands. Where and how the changes would be made will be notably different. Someone taking on that issue or this issue shouldn't need to do the other one in order to resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: commands status: confirmed Confirmed as something that needs working on. type: feature request Shinies.
Development

No branches or pull requests

3 participants