!!/approve on github sometimes doesn't

[tripleee]

What problem has occurred? What issues has it caused?

I added an !!/approve comment on several open PRs here on GitHub. Still PullApprove says "Pending: approval required by one of ...."

I deleted the failed comments and proceeded to approve from chat instead:
#2963 #2957 #2955 #2952

Weirdly, #2951 looks like it was successfully approved, but still not merged. I will proceed to merge that manually.

What would you like to happen/not happen?

Approving on Github should work just like approving from chat.

[makyen]

I agree that it would be nice if a !!/approve comment on GitHub did the same job of approving and merging, with resolving merge conflicts, that a !!/approve PR# does in chat. However, I've never seen it work fully the same (i.e. I've never seen it resolve the merge conflicts we typically get when another !!/watch or !!/approve has been done after the PR was created). It used to automatically merge when there were no conflicts. However, I haven't seen it do that in quite some time.

[angussidney]

If I remember correctly, before !!/approve on GitHub broke, it was using a merge strategy which automatically resolves most of the normal merge conflicts that we get (as a result single-line additions). The word onion rings a bell, but I feel like that's not right (a quick search of the git docs doesn't show up any results. Octopus maybe?)

[ArtOfCode-]

@double-beep metasmoke should automatically merge PRs once they're approved by PullApprove. Sounds like there's a bug there somewhere.

[iBug]

I have a feeling that Charcoal-SE/metasmoke#525 (from me) that removed the creation of .git/info/attributes on MS side might be the cause, but my Git-fu told me this .gitattributes file should always work.

[stale]

This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.