Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work profile notifications #97

Open
kennyeni opened this issue Nov 16, 2021 · 4 comments
Open

Work profile notifications #97

kennyeni opened this issue Nov 16, 2021 · 4 comments

Comments

@kennyeni
Copy link

HI,

I have noticed that not all "Work Profile" notifications are shown on the app. I haven't looked at the code, but I suspect this is because HoleyLight:

  1. Lists all installed packages (only on the main profile though)
  2. Subscribes to all notifications

If on 1. HoleyLight listed all installed packages (irrespective of the profile) it would work.

The reason I'm saying this is because when I have an app installed on both profiles (i.e., Whatsapp as user, and work), HoleyLight works for both. When it's installed only on the Work profile it doesn't work.

Furthermore, I did a test and was able to intercept notifications from only work profile apps using Tasker. So I just think this is a matter of HoleyLight subscribing to all apps :)

P.S. Obviously, the work profile has to enable CrossProfileNoitifications for this to work.

@kennyeni
Copy link
Author

I sent a PR with the changes needed to make this work in a very basic way, you can see details on the PR:
#98

@Chainfire
Copy link
Owner

I remember looking at this some time ago and it didn't work right. Great if you managed to fix it that it does work right. I don't have a work profile in my current setup, how does one enable CrossProfileNotifications? Is it on by default, some setting somewhere? Which version of Android and device did you test this on?

@ghost
Copy link

ghost commented Nov 27, 2021

I actually have the same problem, the app can't see any installed apps from the Work Profile, and I'm without notifications for those apps.

Can you share how you managed to intercept the notifications with Tasker? I have it but I couldn't find an efficient way to achieve it.

Also please answer to @Chainfire so he can maybe implement it and we can do it natively. Thanks!

@kennyeni
Copy link
Author

I remember looking at this some time ago and it didn't work right. Great if you managed to fix it that it does work right. I don't have a work profile in my current setup, how does one enable CrossProfileNotifications? Is it on by default, some setting somewhere? Which version of Android and device did you test this on?

Hi! Sorry for the delay, I never got a notification!

It's off by default as far as I can tell, and had to be enabled through code, I added this option to "Shelter" here: https://gist.github.com/kennyeni/b1c1f90917a5e49abf51ef747b18c90a

I tested this on my Pixel 6 Pro running Android 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants