Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict best LC update collection to canonical blocks #7348

Open
nflaig opened this issue Jan 10, 2025 · 0 comments
Open

Restrict best LC update collection to canonical blocks #7348

nflaig opened this issue Jan 10, 2025 · 0 comments
Labels
help wanted The author indicates that additional help is wanted. scope-light-clients All issues regarding light client development.

Comments

@nflaig
Copy link
Member

nflaig commented Jan 10, 2025

Motivation

Description

Implementation LC spec changes based on ethereum/consensus-specs#3553

Need to enable data_collection tests in spec iterator

lodestar/packages/beacon-node/test/spec/utils/specTestIterator.ts

Line 69 in d793115

/^.+\/light_client\/data_collection\/.*/,

@nflaig nflaig added the scope-light-clients All issues regarding light client development. label Jan 10, 2025
@nflaig nflaig mentioned this issue Jan 10, 2025
Merged
@nflaig nflaig added the help wanted The author indicates that additional help is wanted. label Jan 10, 2025
shitover added a commit to shitover/lodestar that referenced this issue Jan 13, 2025
@shitover
Restrict best LC update collection to canonical blocks
93dc485 
Fixes ChainSafe#7348

Restrict best LC update collection to canonical blocks.

* **beaconBlocksByRange.ts**
  - Filter out non-canonical blocks in `onBeaconBlocksByRange` function.
  - Iterate over filtered head chain instead of the original head chain.

* **blobSidecarsByRange.ts**
  - Filter out non-canonical blocks in `onBlobSidecarsByRange` function.
  - Iterate over filtered head chain instead of the original head chain.

* **archiveBlocks.ts**
  - Filter out non-canonical blocks in `archiveBlocks` function.
  - Map filtered finalized canonical blocks to `finalizedCanonicalBlockRoots`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ChainSafe/lodestar/issues/7348?shareId=XXXX-XXXX-XXXX-XXXX).
@shitover shitover mentioned this issue Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted The author indicates that additional help is wanted. scope-light-clients All issues regarding light client development.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict best LC update collection to canonical blocks shitover/lodestar
1 participant
@nflaig