Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

important: hidden bug window resize cannot work well #30

Open
hbucius opened this issue Nov 29, 2017 · 6 comments
Open

important: hidden bug window resize cannot work well #30

hbucius opened this issue Nov 29, 2017 · 6 comments

Comments

@hbucius
Copy link

hbucius commented Nov 29, 2017

precondition: useNativeClamp = false ; it clamp the container content with ..., when window is small

steps: enlarge the window , thus the container become large, but the it still clamps content event it do not need to clamp

reason: reason is that in dotdotdot function, it always clamps the content with the 'container', event the container content is already clamped in last render.

@CezaryDanielNowak
Copy link
Owner

Could you provide more details? Or demo page?

@Bilyha
Copy link

Bilyha commented Jun 18, 2018

Hi, @CezaryDanielNowak.
This issue is still reproduced.
I prepared a little demo that will allow you to understand what's happening.
video see here
project on sandbox

@brian91dd
Copy link

it's happening to me the same as @Bilyha

@thomasbaldwin
Copy link

thomasbaldwin commented Nov 12, 2018

Happening to me too, any updates @CezaryDanielNowak? I'd really like to use this for a project!

@thomasbaldwin
Copy link

is it because this line only runs once: https://github.com/CezaryDanielNowak/React-dotdotdot/blob/master/src/clamp.js#L264 and doesn't re-run as you resize?

@TomPradat
Copy link

Any updates on this ? I agree this feature would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants