Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Vulcan search #94

Open
wants to merge 3 commits into
base: feature/add-vulcan
Choose a base branch
from

Conversation

XanderVertegaal
Copy link
Contributor

@XanderVertegaal XanderVertegaal commented Jan 9, 2025

#88 should be reviewed first!

Used in combination with the feature/vulcan-search branch of the Vulcan-ParsePort repo, which re-enables searching in Vulcan.

This PR adds two new Websocket actions to the client-side JS code:

  • route_to_layout tells the frontend to navigate to a given ID (to see the result of a particular search);
  • activate_search reconstructs the search parameters, i.e. the structure of the search menu with all parameters the user entered.

@XanderVertegaal XanderVertegaal added enhancement New feature or request minimalist parser Part of the Minimalist Parser demo project (NLP) labels Jan 9, 2025
@XanderVertegaal XanderVertegaal requested a review from Meesch January 9, 2025 15:56
@XanderVertegaal XanderVertegaal changed the title Add route_to_layout websocket action Vulcan search Jan 14, 2025
@XanderVertegaal XanderVertegaal changed the title Vulcan search Feature/Vulcan search Jan 14, 2025
@XanderVertegaal XanderVertegaal linked an issue Jan 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minimalist parser Part of the Minimalist Parser demo project (NLP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Vulcan search
1 participant