Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change card icons shape #56

Closed
TheLastProject opened this issue Oct 24, 2020 · 3 comments
Closed

Change card icons shape #56

TheLastProject opened this issue Oct 24, 2020 · 3 comments
Assignees
@arshbeerSingh
Labels
state: help wanted I looked into this issue but couldn't solve it quickly type: enhancement New feature or request

Comments

@TheLastProject
Copy link
Member

Issue by aha999
Saturday Feb 01, 2020 at 11:16 GMT
Originally opened as brarcher/loyalty-card-locker#354

I think that the card icon's shape could be changed from sharp cornered square to slightly round cornered square. It would look better
@TheLastProject TheLastProject added type: enhancement New feature or request state: help wanted I looked into this issue but couldn't solve it quickly labels Oct 24, 2020
@arshbeerSingh
Copy link
Contributor

@TheLastProject can I work on this issue?

@TheLastProject
Copy link
Member Author

@arshbeerSingh Sure, sounds good. https://material.io/design/shape/about-shape.html#shaping-material states that "Material surfaces have a rectangular shape by default, with 4dp rounded corners" so we should probably use 4dp rounded corners here.

arshbeerSingh added a commit to arshbeerSingh/Catima that referenced this issue Nov 3, 2020
@arshbeerSingh
Fix Issue CatimaLoyalty#56
d897f3b
TheLastProject added a commit that referenced this issue Nov 3, 2020
@TheLastProject
Merge pull request #80 from arshbeerSingh/master
1f962d8 
Fix Issue #56
@TheLastProject
Copy link
Member Author

Fixed in #80, somehow didn't close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arshbeerSingh arshbeerSingh

Labels
state: help wanted I looked into this issue but couldn't solve it quickly type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheLastProject @arshbeerSingh