-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Multiple barcode support #53
Comments
Comment by TheLastProject
|
Comment by TheLastProject I moved the tab bar into the header, which at least makes the situation not worse than it used to be. |
Comment by TheLastProject This sadly seems to conflict with the feature introduced in #348 and I'm not quite sure how to fix that :( |
I'm abandoning this branch because it conflicts with brarcher/loyalty-card-locker#348 and because it probably won't work well with groups either. We need new logic for this. |
Issue by TheLastProject
Saturday Jan 04, 2020 at 23:45 GMT
Originally opened as brarcher/loyalty-card-locker#337
After seeing #279, I felt the tabs were a good way to support multiple barcodes.
Fixes #264 and I feel it also fixes #279 (because multiple barcodes per store make this possible, just note what the code is for). I am also going to assume this fixes #286 as the user's primary concern seems to be an easier way to add another card from a store they already have.
This code groups together every loyalty card with the same store name and, if multiple loyalty cards with the same store name exist, adds a scrollable tabview to switch between them. The text on each tab is based on the note. If there is no note for that specific loyalty card, it falls back to numbering them. It also switches to using a floating action button. Clicking the "+" button when viewing a loyalty card will start the edit activity with the store name pre-filled, to make adding additional cards to the same store easy.
Some screenshots:
TheLastProject included the following code: https://github.com/brarcher/loyalty-card-locker/pull/337/commits
The text was updated successfully, but these errors were encountered: