Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by valid from date #2283

Closed
TheLastProject opened this issue Jan 10, 2025 · 6 comments · Fixed by #2297
Closed

Sort by valid from date #2283

TheLastProject opened this issue Jan 10, 2025 · 6 comments · Fixed by #2297
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: enhancement New feature or request

Comments

@TheLastProject
Copy link
Member

Catima currently allows sorting by expiry, but not by valid from. This is helpful for pkpass files, as they often state the start of an event.

@TheLastProject TheLastProject added type: enhancement New feature or request good first issue Good for newcomers severity: major Severely degrades major functionality or product features, with no satisfactory workaround common: occasional Affects or can be seen by some users regularly or most users rarely labels Jan 10, 2025
@tsiggi
Copy link
Contributor

tsiggi commented Jan 14, 2025

Hello, I want to work on this one.
As it is my first rp i might need some guidance for your project.
I used android studio to run the app.
And if i want to resolve this issue I must add code to the src/java right ?

Thanks in advance, Chris.

@TheLastProject
Copy link
Member Author

Sure, go ahead :)

Yep, it's basically just the same as sorting by expiry. If you search for sort_by_expiry through Catima you'll probably see everywhere you need to change things :)

Please only add an English translation when you add a new translation, it reduces the risk of conflicts with Weblate :)

@tsiggi
Copy link
Contributor

tsiggi commented Jan 15, 2025

Okay I made it work.

Check the following video:
https://github.com/user-attachments/assets/5a7cc124-30fd-41de-98d0-2f6a952963f6

Right now if i change the language the valid from is not being translated.

@TheLastProject
Copy link
Member Author

That's looking good. I think we should probably put "Valid from" above "Expiry" in the options but otherwise looks great. Feel free to send in a merge request :)

Right now if i change the language the valid from is not being translated.

That sounds correct for now. When the code gets merged it will appear in Weblate for translators to translate :)

@tsiggi
Copy link
Contributor

tsiggi commented Jan 15, 2025

Okay perfect. I think i did what you asked.

PS: You were very helpfull, I really appreciate it !!!

@tsiggi
Copy link
Contributor

tsiggi commented Jan 15, 2025

Please let me know if you want anything else in order to close the MR

@TheLastProject TheLastProject linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants