Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKASS display is barebones #2274

Open
papayavice opened this issue Jan 9, 2025 · 3 comments
Open

PKASS display is barebones #2274

papayavice opened this issue Jan 9, 2025 · 3 comments
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely severity: minor Impairs non-critical functionality or suitable workarounds exist subject: design Stuff for designers type: enhancement New feature or request

Comments

@papayavice
Copy link

I am glad that Catima added pkass files support but it is barebones.

I think is better to explain it with a picture, they should look something like this (Apple wallet and Passandroid examples)

f4986ea2f401f49172a179eadf26160c

Screenshot_20250109-191125

This way you can see all the relevant info in one go for boarding pases and so on.

Also, they are sorted by expired time and not by valid from so if you have a boarding pass for something that it goes from one date to another with an expired date later than other boarding pass with and earlier expired date but later valid from (hope it makes sense), the later it will be shown before the former.

A picture of my pkass files ordered by valid from:

Screenshot_20250109-190046

Options to add to calendar or navigate would be great as Passandroid has.

@TheLastProject
Copy link
Member

This seems to be a duplicate of #2264, but this one contains more info, so I'll leave this open instead of #2264.

Luckily Catima does save all the info (to the Notes field), so you can always access it by pressing (i), but yeah, I agree the display could be better (I just figured: waiting for pkpass support to be perfect would have delayed it even more, so let's launch a simple functional version first 🙂)

As I've also written in #2264, I'm not a designer and Android XML is far from my most skilled Android part. I'm mostly wondering about these:

  1. How do we make pkpass display better without "ruining" the display of loyalty cards with way less info? (Maybe we just keep the current layout, remove the field with the name/logo on top (as it's not that important) and put the pkpass fields there? Could be a good start)
  2. How do we deal with the edit screen? Right now, everything is put in the Notes field so its easy to edit, do we just "hide" pkpass info or something? It would definitely be simplest if pkpass info wasn't editable, perhaps start with it being uneditable and later add some simple key/value list?

Also, they are sorted by expired time and not by valid from so if you have a boarding pass for something that it goes from one date to another with an expired date later than other boarding pass with and earlier expired date but later valid from (hope it makes sense), the later it will be shown before the former.

Can you please create a new issue to request sorting by valid from? Having multiple requests in one issue makes it really hard to keep track of what has and hasn't been done. Adding sorting based on valid from would be quite easy.

Options to add to calendar or navigate would be great as Passandroid has.

That's a third and fourth feature request in 1 ticket :)

For calendar: I think it may be nicer if Catima itself could notify you for any card's validity/expiry so it would work more "out of the box" and wouldn't require manual steps from users (see #410).

For navigating: I would expect that to already somewhat work if the card contains GPS coordinates, but being more explicit couldn't hurt. However, that would first require redesigning the screen, I guess the navigating could be part of this screen: if the field is a location type, make it tappable.

@TheLastProject TheLastProject changed the title PKASS files are barebone and lack info PKASS display is barebones Jan 9, 2025
@TheLastProject TheLastProject added type: enhancement New feature or request severity: minor Impairs non-critical functionality or suitable workarounds exist common: occasional Affects or can be seen by some users regularly or most users rarely subject: design Stuff for designers labels Jan 9, 2025
@papayavice
Copy link
Author

Can you please create a new issue

I created new issues as requested.

I don´t know how we can make one without ruining the display of the other type or cards. Apple wallet and Google Wallet do that but I am no developer myself. Just an user, sorry.

@TheLastProject
Copy link
Member

That's fine, thanks :) I'll get to this... at some point. I definitely do agree pkpass handling right now is not good enough, but there is still so much to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely severity: minor Impairs non-critical functionality or suitable workarounds exist subject: design Stuff for designers type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants