Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Google Wallet / NFC when showing QR code #2158

Open
recursiveribbons opened this issue Nov 3, 2024 · 4 comments
Open

Disable Google Wallet / NFC when showing QR code #2158

recursiveribbons opened this issue Nov 3, 2024 · 4 comments
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: enhancement New feature or request

Comments

@recursiveribbons
Copy link
Contributor

Dutch train stations are equipped with a combination QR code scanner and credit card reader, which triggers Google Wallet when a phone is brought up to the reader. Catima should disable the NFC reader while showing a QR code so a user doesn't accidentally pay with a stored credit card while trying to scan a QR code train ticket.

It appears that NfcAdapter.enableReaderMode (docs, so) is the only solution here. Reader mode disables Google Wallet. Enable when a QR code is on screen and disable when not.

@ikanakova
Copy link

ikanakova commented Nov 4, 2024

If you implement this, please do so as an option, because I'm sure a lot of people pay by mobile with Catima running with a QR code is on screen.

@TheLastProject
Copy link
Member

@ikanakova Do you have some cases where you'd want to do this? The use case @recursiveribbons mentioned was very clear and I do want to avoid adding settings for things (almost) nobody would change (as it makes the settings screen more complicated and makes it harder to find the setting you need) and, if we need a setting, I want to make sure it has the right default and is in the right place so I'll need more info about the use cases.

@TheLastProject TheLastProject added type: enhancement New feature or request severity: major Severely degrades major functionality or product features, with no satisfactory workaround common: occasional Affects or can be seen by some users regularly or most users rarely labels Nov 4, 2024
@ikanakova
Copy link

ikanakova commented Nov 5, 2024

The way I use Catima is that I show the QR code of the card to the salesperson and almost immediately pay with my mobile, so I still have Catima open. If Catima disabled the NFC reader while showing a QR code, my mobile payment would not work until I closed the QR code, which I often don't have time to do in the store queue.

@TheLastProject
Copy link
Member

Hmm that makes sense, I've seen someone show a QR code and then pay with their watch while waiting for it to be scanned with another app having similar issues.

Maybe this should be a per-card setting? Some toggle on the card-viewing screen? For Dutch trains it would never make sense to have NFC on while scanning the code, but for other stores you probably want it left on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely severity: major Severely degrades major functionality or product features, with no satisfactory workaround type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants