Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to MaterialDatePicker #1516

Closed
TheLastProject opened this issue Sep 19, 2023 · 12 comments · Fixed by #1588
Closed

Migrate to MaterialDatePicker #1516

TheLastProject opened this issue Sep 19, 2023 · 12 comments · Fixed by #1588
Assignees
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: tolerable Low/no impact on users type: enhancement New feature or request

Comments

@TheLastProject
Copy link
Member

MaterialDatePicker looks a lot more modern, it would be great if the LoyaltyCardEditActivity would use it.

I tried quickly swapping DatePicker for MaterialDatePicker and while that tends to work for dialogs, it didn't want to work in this case. So more research and work is needed.

Tagging as "good first issue" because the scope of this change is very narrow and well-defined and likely needs knowledge of the MaterialDatePicker more than knowledge of Catima. Please note, I am likely unable to help with the initial implementation.

@TheLastProject TheLastProject added type: enhancement New feature or request good first issue Good for newcomers severity: tolerable Low/no impact on users common: occasional Affects or can be seen by some users regularly or most users rarely labels Sep 19, 2023
@Kundai10
Copy link

I would like to work on this issue. Is it still available?

@obfusk
Copy link
Contributor

obfusk commented Sep 24, 2023

@Kundai10 I was considering looking into this but haven't had a chance to do so yet; AFAIK no one else is currently working on this.

@Abdullahkhanspn
Copy link

i will do this issue i know how to implement this please assign to me @TheLastProject

@TheLastProject
Copy link
Member Author

I think @Kundai10 is already planning to work on this, let's give them some time first :)

@Abdullahkhanspn
Copy link

Okay after him please assign me this @TheLastProject

@Kundai10
Copy link

Kundai10 commented Oct 5, 2023

@Abdullahkhanspn you can work on it. I am not working on this issue.

@Abdullahkhanspn
Copy link

okay i will see

@Abdullahkhanspn
Copy link

@Kundai10 can you please tell me how to setup the project locally in android studio. Please tell me i am yesterday clone it in my laptop but when i open and run it on android studio its show soo many gradle build error. Please guide me bro

@Abdullahkhanspn
Copy link

Abdullahkhanspn commented Oct 5, 2023

hey @TheLastProject I think you can now assign this issue to me if you want because @Kundai10 is not working on this .And i can Migrate this to the MaterialDatePicker like this sample its looks modern and user friendly.

MaterialDatePicker Sample

@Abdullahkhanspn
Copy link

hey @TheLastProject can you please tell me how to fix this gradle error i have started working on it but its shows me this.

gradle error please tell how to fix this

@TheLastProject
Copy link
Member Author

Sorry, I don't know. I can build fine myself and so can the GitHub CI, both don't show any such error and I've never seen this error before. I'm sure some StackOverflow thread or Android support community would know the answer to this but I don't have any to point you at either.

(If you ask others for help, I recommend giving them the full error message as the useful info may be anywhere, you're only showing me the first 20 or so percent of it here)

@Abdullahkhanspn
Copy link

Okay, I understand the error I thinks it's a very simple setting the setting of my android studio was changed. I will fix this soon the code is all good the error is coming from my settings i think. I will Fixed it soon.
And Thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: tolerable Low/no impact on users type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants