Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show project releases and/or metrics #647

Closed
mdoering opened this issue Jun 11, 2020 · 8 comments
Closed

Show project releases and/or metrics #647

mdoering opened this issue Jun 11, 2020 · 8 comments

Comments

@mdoering
Copy link
Member

This dataset has never been released.
https://data.catalogue.life/dataset/3/imports

There are releases, but it seems the page is the import page that is trying to list imports?
Releases should be a separate page

@mdoering mdoering added the bug label Jun 11, 2020
@mdoering
Copy link
Member Author

alternative option to show releases here: #640

I would suggest to follow #640 and just show a link, date and count in metadata.

@thomasstjerne
Copy link
Contributor

But at some point there was metrics for the release here: https://api.catalogue.life/dataset/3/import?limit=20
Did the endpoint for that change?

@mdoering
Copy link
Member Author

I am not sure what the page tries to show. The URL is called imports, so I guess its supposed to show the import metrics. The project itself does not have import metrics unless you have imported archives, e.g. via uploads.

Every release does have a single metric. But that belongs to the released dataset key, not the mother project.

If I understand the intentions correctly I would suggest to:

@thomasstjerne
Copy link
Contributor

thomasstjerne commented Jun 12, 2020

When a managed dataset is released we generate one import metric.

Ok. I must have misunderstood this one: #513

@mdoering
Copy link
Member Author

Ah yes. Just the generated metrics are for the release, not the master project.
For a single release we do show the metrics correctly: https://data.catalogue.life/dataset/2140/imports

I never know whether "Imports" or "Metrics" is a better title for the page

@thomasstjerne
Copy link
Contributor

But if we should be able to track history/changes I would suggest that this call: https://api.catalogue.life/dataset/3/import?limit=20
returned the metrics for all releases of dataset 3
Endpoint could maybe /release instead for more intuitiveness

Then you would have a nice release history here: https://data.catalogue.life/dataset/3/imports

Of course I can change the url to /dataset/3/releases so it align with the menu text.

Otherwise I could show a list of released datasets from where you could click to their respective release metrics - but that wouldn´t be the best workflow

@thomasstjerne thomasstjerne added design and removed bug labels Jun 12, 2020
@mdoering
Copy link
Member Author

That makes sense. But what about plain imports like uploads? Should we ignore those for managed datasets? Or we indeed create new release endpoints both on API and UI which seems to make also more sense semantically

@mdoering
Copy link
Member Author

mdoering commented Jun 12, 2020

As releases are different datasets the regular diff API does not work as it expects the same datasetKey or sectorKey. But with a new releases endpoint we could also create such a diff tool to show changes between releases - which sounds actually more interesting then between imports.

@mdoering mdoering changed the title Draft has never been released? Show project releases and/or metrics Mar 15, 2021
@mdoering mdoering added this to the Annual Checklist milestone Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants