feat: remove cast to prevent null from being incorrectly converted

CapgeminiInventUK · Jan 12, 2024 · 14c4d41 · 14c4d41
1 parent 20b15cb
commit 14c4d41
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/handlers/schoolData.ts b/src/handlers/schoolData.ts
@@ -61,10 +61,7 @@ export const lambdaHandler = async (): Promise<{ statusCode: number }> => {
         const match = currentSchools.find((school) => school.urn === urn);
         logger.info(`${easting} ${northing}`);
 
-        const [longitude, latitude] = convertEastingNorthingtoLatLng(
-          Number(easting),
-          Number(northing)
-        );
+        const [longitude, latitude] = convertEastingNorthingtoLatLng(easting, northing);
 
         const entry = {
           urn,

diff --git a/src/shared/location.ts b/src/shared/location.ts
@@ -5,10 +5,10 @@ const osgb =
 const wgs84 = '+proj=longlat +datum=WGS84 +no_defs ';
 
 export const convertEastingNorthingtoLatLng = (
-  easting: number,
-  northing: number
+  easting: number | string | null,
+  northing: number | string | null
 ): [number, number] => {
-  if (!easting || !northing || isNaN(easting) || isNaN(northing)) {
+  if (!easting || !northing || isNaN(Number(easting)) || isNaN(Number(northing))) {
     return [0, 0];
   }